Re: Proposal: adding --enable-shadows-warning

2025-11-28 Thread Nazir Bilal Yavuz
Hi, On Fri, 28 Nov 2025 at 12:40, Chao Li wrote: > > > On Nov 28, 2025, at 17:20, Daniel Gustafsson wrote: > > > >> On 28 Nov 2025, at 10:02, Chao Li wrote: > > > >> To make hacker’s life easier, it would make sense to always enable > >> “-Wshadow”, however, that may have a risk of breaking so

Re: Proposal: adding --enable-shadows-warning

2025-11-28 Thread Chao Li
> On Nov 28, 2025, at 17:20, Daniel Gustafsson wrote: > >> On 28 Nov 2025, at 10:02, Chao Li wrote: > >> To make hacker’s life easier, it would make sense to always enable >> “-Wshadow”, however, that may have a risk of breaking some compilers. So >> thinking over, I just fell adding an op

Re: Proposal: adding --enable-shadows-warning

2025-11-28 Thread Daniel Gustafsson
> On 28 Nov 2025, at 10:02, Chao Li wrote: > To make hacker’s life easier, it would make sense to always enable > “-Wshadow”, however, that may have a risk of breaking some compilers. So > thinking over, I just fell adding an opt-in “—enable-shadows-warnings” could > be a solution. I'm not su

Proposal: adding --enable-shadows-warning

2025-11-28 Thread Chao Li
Hi Hackers, I had an experience where I made a patch ready locally, build passed without any warning, however, CommitFest CI failed with a compile waring of shadows variable. I felt strange at the time but now I understand that is because some compilers, like clang I am using, don’t enable -Wsh