Re: Problems around compute_query_id

2021-04-22 Thread Julien Rouhaud
On Tue, Apr 20, 2021 at 12:59:10PM -0400, Bruce Momjian wrote: > On Thu, Apr 15, 2021 at 03:43:59PM +0800, Julien Rouhaud wrote: > > On Mon, Apr 12, 2021 at 02:56:59PM +0800, Julien Rouhaud wrote: > > > I think we should simply document that %Q is not compatible with > > > log_statements. > > > >

Re: Problems around compute_query_id

2021-04-20 Thread Bruce Momjian
On Thu, Apr 15, 2021 at 03:43:59PM +0800, Julien Rouhaud wrote: > On Mon, Apr 12, 2021 at 02:56:59PM +0800, Julien Rouhaud wrote: > > I think we should simply document that %Q is not compatible with > > log_statements. > > Hearing no objection I documented that limitation. > > > > > > While maki

Re: Problems around compute_query_id

2021-04-15 Thread Julien Rouhaud
On Mon, Apr 12, 2021 at 02:56:59PM +0800, Julien Rouhaud wrote: > I think we should simply document that %Q is not compatible with > log_statements. Hearing no objection I documented that limitation. > > > While making the feature run on some test server, I have noticed that > > %Q would log som

Re: Problems around compute_query_id

2021-04-12 Thread Julien Rouhaud
On Mon, Apr 12, 2021 at 03:26:33PM +0800, Julien Rouhaud wrote: > On Mon, Apr 12, 2021 at 09:20:07AM +0200, Michael Banck wrote: > > > > What about log_statement_sample_rate ? Does compute_query_id have the > > same problem with that? > > No, log_statement_sample_rate samples log_min_duration_sta

Re: Problems around compute_query_id

2021-04-12 Thread Julien Rouhaud
On Mon, Apr 12, 2021 at 09:20:07AM +0200, Michael Banck wrote: > > What about log_statement_sample_rate ? Does compute_query_id have the > same problem with that? No, log_statement_sample_rate samples log_min_duration_statements, not log_statements so it works as expected.

Re: Problems around compute_query_id

2021-04-12 Thread Michael Banck
Hi, On Mon, Apr 12, 2021 at 02:56:59PM +0800, Julien Rouhaud wrote: > On Mon, Apr 12, 2021 at 03:12:40PM +0900, Michael Paquier wrote: > > Fujii-san has reported on Twitter that enabling the computation of > > query IDs does not work properly with log_statement as the query ID is > > calculated at

Re: Problems around compute_query_id

2021-04-11 Thread Julien Rouhaud
On Mon, Apr 12, 2021 at 03:12:40PM +0900, Michael Paquier wrote: > Hi all, > > Starting a new thread as the one that has introduced compute_query_id > is already long enough. > > Fujii-san has reported on Twitter that enabling the computation of > query IDs does not work properly with log_stateme

Problems around compute_query_id

2021-04-11 Thread Michael Paquier
Hi all, Starting a new thread as the one that has introduced compute_query_id is already long enough. Fujii-san has reported on Twitter that enabling the computation of query IDs does not work properly with log_statement as the query ID is calculated at parse analyze time and the query is logged