Re: Print logical WAL message content

2020-09-13 Thread Ashutosh Bapat
On Fri, 11 Sep 2020 at 04:08, Alvaro Herrera wrote: > > Pushed, thanks! > Thanks Alvaro. -- Best Wishes, Ashutosh

Re: Print logical WAL message content

2020-09-10 Thread Alvaro Herrera
On 2020-Aug-19, Ashutosh Bapat wrote: > I like this format as well. Done. > > PFA the patch attached with your comments addressed. Pushed, thanks! -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: Print logical WAL message content

2020-08-19 Thread Ashutosh Bapat
Thanks Alvaro for review. On Wed, Aug 19, 2020 at 3:21 AM Alvaro Herrera wrote: > > I didn't like that you're documenting the message format in the new > function: > > > xl_logical_message *xlrec = (xl_logical_message *) rec; > > + /* > > + * Per LogLogicalM

Re: Print logical WAL message content

2020-08-18 Thread Alvaro Herrera
On 2020-Aug-18, Ashutosh Bapat wrote: > Right now pg_waldump just prints whether the message is transactional > or not and its size. That doesn't help much to understand the message > itself. If it prints the contents of a logical WAL message, it helps > debugging logical replication related probl

Print logical WAL message content

2020-08-17 Thread Ashutosh Bapat
Hi, Right now pg_waldump just prints whether the message is transactional or not and its size. That doesn't help much to understand the message itself. If it prints the contents of a logical WAL message, it helps debugging logical replication related problems. Prefix is a null-terminated ASCII stri