Re: Potential (low likelihood) wraparound hazard in heap_abort_speculative()

2020-03-29 Thread Andres Freund
Hi, On 2020-03-29 15:20:01 -0700, Peter Geoghegan wrote: > On Sat, Mar 28, 2020 at 2:30 PM Andres Freund wrote: > > Unless somebody has a better idea for how to solve this in a > > back-paptchable way, I think it'd be best to replace RecentGlobalXmin > > with RecentXmin. That'd be safe as far as

Re: Potential (low likelihood) wraparound hazard in heap_abort_speculative()

2020-03-29 Thread Peter Geoghegan
On Sat, Mar 28, 2020 at 2:30 PM Andres Freund wrote: > Unless somebody has a better idea for how to solve this in a > back-paptchable way, I think it'd be best to replace RecentGlobalXmin > with RecentXmin. That'd be safe as far as I can see. As far as I can tell, the worst consequence of this wr

Potential (low likelihood) wraparound hazard in heap_abort_speculative()

2020-03-28 Thread Andres Freund
Hi, heap_abort_speculative() does: /* * The tuple will become DEAD immediately. Flag that this page * immediately is a candidate for pruning by setting xmin to * RecentGlobalXmin. That's not pretty, but it doesn't seem worth * inventing a nicer API for