Re: Possible null pointer dereference in afterTriggerAddEvent()

2024-09-25 Thread Alvaro Herrera
On 2024-Sep-24, Alvaro Herrera wrote: > On 2024-Sep-24, Alexander Kuznetsov wrote: > > > is there anything else we can help with or discuss in order to apply this > > fix? > > I don't think so, it seems a no-brainer to me and there are no > objections. I'll get it pushed tomorrow. OK, done.

Re: Possible null pointer dereference in afterTriggerAddEvent()

2024-09-24 Thread Alvaro Herrera
On 2024-Sep-24, Alexander Kuznetsov wrote: > Hello, > > is there anything else we can help with or discuss in order to apply this fix? I don't think so, it seems a no-brainer to me and there are no objections. I'll get it pushed tomorrow. -- Álvaro Herrera PostgreSQL Developer — htt

Re: Possible null pointer dereference in afterTriggerAddEvent()

2024-09-24 Thread Alexander Kuznetsov
Hello, is there anything else we can help with or discuss in order to apply this fix? 26.07.2024 12:16, Alexander Kuznetsov пишет: 25.07.2024 20:07, Alvaro Herrera wrote: Maybe for sanity (and perhaps for Svace compliance) we could do it the other way around, i.e. by testing events->tail for n

Re: Possible null pointer dereference in afterTriggerAddEvent()

2024-07-26 Thread Alexander Kuznetsov
25.07.2024 20:07, Alvaro Herrera wrote: Maybe for sanity (and perhaps for Svace compliance) we could do it the other way around, i.e. by testing events->tail for nullness instead of events->head, then add the assertion: if (events->tail == NULL) {

Re: Possible null pointer dereference in afterTriggerAddEvent()

2024-07-25 Thread Alvaro Herrera
On 2024-Jul-25, Alexander Kuznetsov wrote: Hello Alexander, > In src/backend/commands/trigger.c:4031, there is an > afterTriggerAddEvent() function. The variable chunk is assigned the > value of events->tail at line 4050. Subsequently, chunk is compared to > NULL at lines 4051 and 4079, indicatin

Possible null pointer dereference in afterTriggerAddEvent()

2024-07-25 Thread Alexander Kuznetsov
Hello everyone, In src/backend/commands/trigger.c:4031, there is an afterTriggerAddEvent() function. The variable chunk is assigned the value of events->tail at line 4050. Subsequently, chunk is compared to NULL at lines 4051 and 4079, indicating that events->tail could potentially be NULL. H