Re: Possible memory leak in pgcrypto with EVP_MD_CTX

2020-10-18 Thread Michael Paquier
On Thu, Oct 15, 2020 at 04:22:12PM +0900, Michael Paquier wrote: > That's a bit annoying, because this memory is allocated directly by > OpenSSL, and Postgres does not know how to free it until it gets > registered in the list of open_digests that would be used by the > cleanup callback, so I think

Possible memory leak in pgcrypto with EVP_MD_CTX

2020-10-15 Thread Michael Paquier
Hi all, It happens that pgcrypto has the following leak if a digest cannot be initialized: --- a/contrib/pgcrypto/openssl.c +++ b/contrib/pgcrypto/openssl.c @@ -202,6 +202,7 @@ px_find_digest(const char *name, PX_MD **res) } if (EVP_DigestInit_ex(ctx, md, NULL) == 0) { + EVP_MD_C