Re: Possible false valgrind error reports

2023-02-21 Thread Tom Lane
Karina Litskevich writes: > Thank you, I moved comment changes to 0001 and rewrote the fix through Min(). Looks good. I pushed it after a little more fiddling with the comments. Thanks for the report and patch! regards, tom lane

Re: Possible false valgrind error reports

2023-02-17 Thread Karina Litskevich
Thank you, I moved comment changes to 0001 and rewrote the fix through Min(). > The first hunk in 0001 doesn't seem quite right yet: > > * old allocation. > */ > #ifdef USE_VALGRIND > -if (oldsize > chunk->requested_size) > +if (size > chunk->requested_size &&

Re: Possible false valgrind error reports

2023-02-14 Thread Tom Lane
Karina Litskevich writes: > In 82d0a46ea32 AllocSetRealloc() was changed to allow decreasing size of > external chunks and give memory back to the malloc pool. Two > VALGRIND_MAKE_MEM_UNDEFINED() calls were not changed to work properly in the > case of decreasing size: they can mark memory behind

Possible false valgrind error reports

2023-02-14 Thread Karina Litskevich
Hi hackers, In 82d0a46ea32 AllocSetRealloc() was changed to allow decreasing size of external chunks and give memory back to the malloc pool. Two VALGRIND_MAKE_MEM_UNDEFINED() calls were not changed to work properly in the case of decreasing size: they can mark memory behind the new allocated memo