Re: Possible fails in pg_stat_statements test

2022-07-09 Thread Anton A. Melnikov
On 06.07.2022 20:11, Robert Haas wrote: On Thu, Mar 31, 2022 at 12:00 PM Julien Rouhaud wrote: Indeed. Then there is a very simple solution for this particular case as wal_records counter may only sometime becomes greater but never less. The corresponding patch is attached. +1 for this app

Re: Possible fails in pg_stat_statements test

2022-07-06 Thread Robert Haas
On Thu, Mar 31, 2022 at 12:00 PM Julien Rouhaud wrote: > > Indeed. Then there is a very simple solution for this particular case as > > wal_records counter may only sometime becomes greater but never less. > > The corresponding patch is attached. > > +1 for this approach, and the patch looks good

Re: Possible fails in pg_stat_statements test

2022-03-31 Thread Julien Rouhaud
Hi, On Thu, Mar 31, 2022 at 06:08:01PM +0300, Anton A. Melnikov wrote: > Hello! > > On 30.03.2022 22:36, Robert Haas wrote: > > I don't think that the idea of "extra" WAL records is very principled. > > It's pretty vague what "extra" means, and your definition seems to be > > basically "whatever

Re: Possible fails in pg_stat_statements test

2022-03-31 Thread Anton A. Melnikov
es Professional: http://www.postgrespro.com The Russian Postgres Companycommit 742d16413ebfe4f556e0f676a3a8785b638d245a Author: Anton A. Melnikov Date: Thu Mar 31 18:00:07 2022 +0300 Fix possible fails in pg_stat_statements test via test rework. diff --git a/contrib/pg_stat_statements/expected/pg_stat_statements.out

Re: Possible fails in pg_stat_statements test

2022-03-30 Thread Robert Haas
On Wed, Mar 30, 2022 at 2:20 AM Anton A. Melnikov wrote: > > Can the test failures be encountered without such an elaborate setup? If > > not, > > then I don't really see why we need to do anything here? > > There was a real bug report from our test department. They do long time > repetitive test

Re: Possible fails in pg_stat_statements test

2022-03-29 Thread Anton A. Melnikov
s Companycommit 2cc4234754fc815528ed299b64c1a3f1e1991617 Author: Anton A. Melnikov Date: Wed Mar 30 08:54:51 2022 +0300 Fix possible fails in pg_stat_statements test via taking into account WAL records due to on-access pruning and new clog page generation. diff --git a/contrib/pg_stat_statements/Mak

Re: Possible fails in pg_stat_statements test

2022-03-20 Thread Andres Freund
Hi, On 2022-01-14 11:11:07 +0300, Anton A. Melnikov wrote: > This patch introduces an additional counter of wal records not related to > the query being executed. They're not unrelated though. > Due to this counter pg_stat_statement finds out the number of wal records > that are not relevant to

Re: Possible fails in pg_stat_statements test

2022-03-20 Thread Anton A. Melnikov
04ce779eb25fec3364c216202b7d7dbd3ed79819 Author: Anton A. Melnikov Date: Sun Mar 20 19:34:58 2022 +0300 Fix possible fails in pg_stat_statements test via taking into account non-query wal records. diff --git a/contrib/pg_stat_statements/pg_stat_statements.c b/contrib/pg_stat_statements

Possible fails in pg_stat_statements test

2022-01-14 Thread Anton A. Melnikov
82a6add7949fbebe2 Author: Anton A. Melnikov Date: Fri Jan 14 10:54:35 2022 +0300 Fix possible fails in pg_stat_statements test via taking into account non-query wal records. diff --git a/contrib/pg_stat_statements/pg_stat_statements.c b/contrib/pg_stat_statements/pg_stat_statements.c index 08