Re: Polyphase merge is obsolete

2023-01-23 Thread Heikki Linnakangas
On 16/01/2023 12:23, Peter Eisentraut wrote: On 21.11.22 10:29, Peter Eisentraut wrote: On 21.11.22 00:57, Heikki Linnakangas wrote: On 19/11/2022 13:00, Peter Eisentraut wrote: AFAICT, this thread updated the API of LogicalTapeSetCreate() in PG15, but did not adequately update the function he

Re: Polyphase merge is obsolete

2023-01-16 Thread Peter Eisentraut
On 21.11.22 10:29, Peter Eisentraut wrote: On 21.11.22 00:57, Heikki Linnakangas wrote: On 19/11/2022 13:00, Peter Eisentraut wrote: On 18.10.21 14:15, Heikki Linnakangas wrote: On 05/10/2021 20:24, John Naylor wrote: I've had a chance to review and test out the v5 patches. Thanks! I fixed

Re: Polyphase merge is obsolete

2022-11-21 Thread Peter Eisentraut
On 21.11.22 00:57, Heikki Linnakangas wrote: On 19/11/2022 13:00, Peter Eisentraut wrote: On 18.10.21 14:15, Heikki Linnakangas wrote: On 05/10/2021 20:24, John Naylor wrote: I've had a chance to review and test out the v5 patches. Thanks! I fixed the stray reference to PostgreSQL 14 that Zh

Re: Polyphase merge is obsolete

2022-11-20 Thread Heikki Linnakangas
On 19/11/2022 13:00, Peter Eisentraut wrote: On 18.10.21 14:15, Heikki Linnakangas wrote: On 05/10/2021 20:24, John Naylor wrote: I've had a chance to review and test out the v5 patches. Thanks! I fixed the stray reference to PostgreSQL 14 that Zhihong mentioned, and pushed. AFAICT, this th

Re: Polyphase merge is obsolete

2022-11-19 Thread Peter Eisentraut
On 18.10.21 14:15, Heikki Linnakangas wrote: On 05/10/2021 20:24, John Naylor wrote: I've had a chance to review and test out the v5 patches. Thanks! I fixed the stray reference to PostgreSQL 14 that Zhihong mentioned, and pushed. AFAICT, this thread updated the API of LogicalTapeSetCreate(

Re: Polyphase merge is obsolete

2021-10-18 Thread Heikki Linnakangas
On 05/10/2021 20:24, John Naylor wrote: I've had a chance to review and test out the v5 patches. Thanks! I fixed the stray reference to PostgreSQL 14 that Zhihong mentioned, and pushed. I've done some performance testing of master versus both patches applied. The full results and test scrip

Re: Polyphase merge is obsolete

2021-10-05 Thread Peter Geoghegan
On Tue, Oct 5, 2021 at 10:25 AM John Naylor wrote: > int64 is used elsewhere in this file, and I see now reason to do otherwise. Right. The point of using int64 in tuplesort.c is that the values may become negative in certain edge-cases. The whole LACKMEM() concept that tuplesort.c uses to enforc

Re: Polyphase merge is obsolete

2021-10-05 Thread John Naylor
On Wed, Sep 15, 2021 at 5:35 PM Heikki Linnakangas wrote: > Thanks, here's another rebase. > > - Heikki I've had a chance to review and test out the v5 patches. 0001 is a useful simplification. Nothing in 0002 stood out as needing comment. I've done some performance testing of master versus bot

Re: Polyphase merge is obsolete

2021-09-15 Thread Heikki Linnakangas
On 16/09/2021 00:12, Jaime Casanova wrote: On Sat, Sep 11, 2021 at 01:35:27AM -0500, Jaime Casanova wrote: On Wed, Jul 14, 2021 at 06:04:14PM +0300, Heikki Linnakangas wrote: On 14/07/2021 15:12, vignesh C wrote: On Sat, Jan 23, 2021 at 3:49 AM Heikki Linnakangas wrote: Here's an updated ver

Re: Polyphase merge is obsolete

2021-09-15 Thread Jaime Casanova
On Sat, Sep 11, 2021 at 01:35:27AM -0500, Jaime Casanova wrote: > On Wed, Jul 14, 2021 at 06:04:14PM +0300, Heikki Linnakangas wrote: > > On 14/07/2021 15:12, vignesh C wrote: > > > On Sat, Jan 23, 2021 at 3:49 AM Heikki Linnakangas > > > wrote: > > > > Here's an updated version that fixes one bu

Re: Polyphase merge is obsolete

2021-09-11 Thread Zhihong Yu
On Fri, Sep 10, 2021 at 11:35 PM Jaime Casanova < jcasa...@systemguards.com.ec> wrote: > On Wed, Jul 14, 2021 at 06:04:14PM +0300, Heikki Linnakangas wrote: > > On 14/07/2021 15:12, vignesh C wrote: > > > On Sat, Jan 23, 2021 at 3:49 AM Heikki Linnakangas > wrote: > > > > Here's an updated versio

Re: Polyphase merge is obsolete

2021-09-10 Thread Jaime Casanova
On Wed, Jul 14, 2021 at 06:04:14PM +0300, Heikki Linnakangas wrote: > On 14/07/2021 15:12, vignesh C wrote: > > On Sat, Jan 23, 2021 at 3:49 AM Heikki Linnakangas wrote: > > > Here's an updated version that fixes one bug: > > > > > > The CFBot was reporting a failure on the FreeBSD system [1]. It

Re: Polyphase merge is obsolete

2021-07-14 Thread Heikki Linnakangas
On 14/07/2021 15:12, vignesh C wrote: On Sat, Jan 23, 2021 at 3:49 AM Heikki Linnakangas wrote: Here's an updated version that fixes one bug: The CFBot was reporting a failure on the FreeBSD system [1]. It turned out to be an out-of-memory issue caused by an underflow bug in the calculation of

Re: Polyphase merge is obsolete

2021-07-14 Thread vignesh C
On Sat, Jan 23, 2021 at 3:49 AM Heikki Linnakangas wrote: > > On 22/10/2020 14:48, Heikki Linnakangas wrote: > > On 11/09/2017 13:37, Tomas Vondra wrote: > >> I planned to do some benchmarking on this patch, but apparently the > >> patch no longer applies. Rebase please? > > > > Here's a rebase of

Re: Polyphase merge is obsolete

2021-03-25 Thread David Steele
On 3/25/21 9:41 AM, David Steele wrote: On 1/22/21 5:19 PM, Heikki Linnakangas wrote: On 22/10/2020 14:48, Heikki Linnakangas wrote: On 11/09/2017 13:37, Tomas Vondra wrote: I planned to do some benchmarking on this patch, but apparently the patch no longer applies. Rebase please? Here's a r

Re: Polyphase merge is obsolete

2021-03-25 Thread David Steele
On 1/22/21 5:19 PM, Heikki Linnakangas wrote: On 22/10/2020 14:48, Heikki Linnakangas wrote: On 11/09/2017 13:37, Tomas Vondra wrote: I planned to do some benchmarking on this patch, but apparently the patch no longer applies. Rebase please? Here's a rebase of this. Sorry to keep you waiting

Re: Polyphase merge is obsolete

2021-01-22 Thread Heikki Linnakangas
On 22/10/2020 14:48, Heikki Linnakangas wrote: On 11/09/2017 13:37, Tomas Vondra wrote: I planned to do some benchmarking on this patch, but apparently the patch no longer applies. Rebase please? Here's a rebase of this. Sorry to keep you waiting :-). Here's an updated version that fixes one