Re: PlaceHolderVars in pushed down child-join cause error

2018-02-25 Thread Ashutosh Bapat
On Thu, Feb 22, 2018 at 8:36 PM, Robert Haas wrote: > On Thu, Feb 22, 2018 at 7:41 AM, Ashutosh Bapat > wrote: >> postgres_fdw isn't expected to push down joins with placeholder vars. >> But the check for that in foreign_join_ok() only considers >> joinrel->relids. For a child-join relids contain

Re: PlaceHolderVars in pushed down child-join cause error

2018-02-22 Thread Robert Haas
On Thu, Feb 22, 2018 at 7:41 AM, Ashutosh Bapat wrote: > postgres_fdw isn't expected to push down joins with placeholder vars. > But the check for that in foreign_join_ok() only considers > joinrel->relids. For a child-join relids contains the child relids but > PlaceHolderInfo refers to the top p

PlaceHolderVars in pushed down child-join cause error

2018-02-22 Thread Ashutosh Bapat
Hi, postgres_fdw isn't expected to push down joins with placeholder vars. But the check for that in foreign_join_ok() only considers joinrel->relids. For a child-join relids contains the child relids but PlaceHolderInfo refers to the top parent's relids. Hence postgres_fdw tries to push down a chil