Re: Periodic FSM vacuum doesn't happen in one-pass strategy vacuum.

2025-04-07 Thread Masahiko Sawada
On Mon, Apr 7, 2025 at 8:30 AM Melanie Plageman wrote: > > On Fri, Apr 4, 2025 at 6:07 PM Masahiko Sawada wrote: > > > > I'm going to push this fix up to HEAD and v17 early next week, unless > > there is no objection. > > I started studying this again looking back at the thread associated > with

Re: Periodic FSM vacuum doesn't happen in one-pass strategy vacuum.

2025-04-07 Thread Melanie Plageman
On Fri, Apr 4, 2025 at 6:07 PM Masahiko Sawada wrote: > > I'm going to push this fix up to HEAD and v17 early next week, unless > there is no objection. I started studying this again looking back at the thread associated with commit c120550edb86. There was actually a long discussion about how thi

Re: Periodic FSM vacuum doesn't happen in one-pass strategy vacuum.

2025-04-04 Thread Masahiko Sawada
On Mon, Mar 31, 2025 at 3:29 PM Masahiko Sawada wrote: > > On Mon, Mar 31, 2025 at 3:12 PM Melanie Plageman > wrote: > > > > On Mon, Mar 31, 2025 at 6:03 PM Masahiko Sawada > > wrote: > > > > > > With commit c120550edb86, If we got the cleanup lock on the page, > > > lazy_scan_prune() marks dea

Re: Periodic FSM vacuum doesn't happen in one-pass strategy vacuum.

2025-03-31 Thread Masahiko Sawada
On Mon, Mar 31, 2025 at 3:12 PM Melanie Plageman wrote: > > On Mon, Mar 31, 2025 at 6:03 PM Masahiko Sawada wrote: > > > > With commit c120550edb86, If we got the cleanup lock on the page, > > lazy_scan_prune() marks dead item IDs directly to LP_UNUSED. So the > > following check with has_lpdead_

Re: Periodic FSM vacuum doesn't happen in one-pass strategy vacuum.

2025-03-31 Thread Melanie Plageman
On Mon, Mar 31, 2025 at 6:03 PM Masahiko Sawada wrote: > > With commit c120550edb86, If we got the cleanup lock on the page, > lazy_scan_prune() marks dead item IDs directly to LP_UNUSED. So the > following check with has_lpdead_items made the periodic FSM vacuum in > the one-pass strategy vacuum

Periodic FSM vacuum doesn't happen in one-pass strategy vacuum.

2025-03-31 Thread Masahiko Sawada
Hi, With commit c120550edb86, If we got the cleanup lock on the page, lazy_scan_prune() marks dead item IDs directly to LP_UNUSED. So the following check with has_lpdead_items made the periodic FSM vacuum in the one-pass strategy vacuum no longer being triggered: if (got_cleanup_lock