Re: Patch: New GUC prepared_statement_limit to limit memory used by prepared statements

On Tue, Sep 03, 2019 at 06:30:32PM -0400, Tom Lane wrote: > Oh ... actually, I bet the problem is that the patch thinks it's okay > to immediately free space in PlanCacheRelCallback and friends, rather > than just marking invalid entries as invalid. Nope, you cannot do that. > You can't tell wheth

Re: Patch: New GUC prepared_statement_limit to limit memory used by prepared statements

I wrote: > As far as the crash issue is concerned, I notice that right now the > cfbot is showing green for this patch, but that seems to just be because > the behavior is unstable. I see crashes in "make installcheck-parallel" > about 50% of the time with this patch applied. Since, in fact, > th

Re: Patch: New GUC prepared_statement_limit to limit memory used by prepared statements

Alvaro Herrera writes: > On this patch, beyond the fact that it's causing a crash in the > regression tests as evidenced by the CFbot, we seem to be waiting on the > input of the larger community on whether it's a desired feature or not. > We have Kyotaro's vote for it, but it would be good to get

Re: Patch: New GUC prepared_statement_limit to limit memory used by prepared statements

On 2019-Aug-18, Daniel Migowski wrote: > >  - Is this a WIP patch or the final patch? Because I can see TODO > > and non-standard comments in the patch. > > Definitely work in progress! The current implementation seems to work for > me, but might be improved, but I wanted some input from the mail

Re: Patch: New GUC prepared_statement_limit to limit memory used by prepared statements

Am 19.08.2019 um 05:57 schrieb Kyotaro Horiguchi: At Sun, 18 Aug 2019 09:43:09 +0200, Daniel Migowski wrote in <6e25ca12-9484-8994-a1ee-40fdbe6af...@ikoffice.de> Am 17.08.2019 um 19:10 schrieb Ibrar Ahmed: On Sat, Aug 17, 2019 at 6:58 PM Daniel Migowski mailto:dmigow...@ikoffice.de>> wrote:

Re: Patch: New GUC prepared_statement_limit to limit memory used by prepared statements

Hello, At Sun, 18 Aug 2019 09:43:09 +0200, Daniel Migowski wrote in <6e25ca12-9484-8994-a1ee-40fdbe6af...@ikoffice.de> > Am 17.08.2019 um 19:10 schrieb Ibrar Ahmed: > > On Sat, Aug 17, 2019 at 6:58 PM Daniel Migowski > > wrote: > > > > > > attached you find a p

Re: Patch: New GUC prepared_statement_limit to limit memory used by prepared statements

Am 17.08.2019 um 19:10 schrieb Ibrar Ahmed: On Sat, Aug 17, 2019 at 6:58 PM Daniel Migowski > wrote: attached you find a patch that adds a new GUC: Quick questions before looking at the patch. prepared_statement_limit:  - Do we have a consensus about t

Re: Patch: New GUC prepared_statement_limit to limit memory used by prepared statements

On Sat, Aug 17, 2019 at 6:58 PM Daniel Migowski wrote: > Hello, > > attached you find a patch that adds a new GUC: > Quick questions before looking at the patch. > > prepared_statement_limit: > > - Do we have a consensus about the name of GUC? I don't think it is the right name for that. - I

Patch: New GUC prepared_statement_limit to limit memory used by prepared statements

Hello, attached you find a patch that adds a new GUC: prepared_statement_limit:         Specifies the maximum amount of memory used in each session to cache         parsed-and-rewritten queries and execution plans. This affects the maximum memory     a backend threads will reserve when ma