On Thu, Oct 8, 2020 at 2:58 PM Amit Langote wrote:
> On Wed, Oct 7, 2020 at 12:51 AM Tom Lane wrote:
> > Ashutosh Bapat writes:
> > > On Mon, Oct 5, 2020 at 11:59 PM Tom Lane wrote:
> > >> ... we could avoid the growth in eclass members for large partition sets
> > >> if we simply didn't store
On Wed, Oct 7, 2020 at 12:51 AM Tom Lane wrote:
> Ashutosh Bapat writes:
> > On Mon, Oct 5, 2020 at 11:59 PM Tom Lane wrote:
> >> ... we could avoid the growth in eclass members for large partition sets
> >> if we simply didn't store child eclass members, instead translating
> >> on-the-fly when
On Mon, Oct 5, 2020 at 2:29 PM Tom Lane wrote:
> Actually, the reason I have been looking at equivclass.c is that I've
> been attacking the problem from a different direction. I'm fairly
> unexcited about making the definition of Var looser as you suggest
> here --- I actually think that it's dan
Ashutosh Bapat writes:
> On Mon, Oct 5, 2020 at 11:59 PM Tom Lane wrote:
>> ... we could avoid the growth in eclass members for large partition sets
>> if we simply didn't store child eclass members, instead translating
>> on-the-fly when we need to deal with child rels. I have a patch
>> about
On Mon, Oct 5, 2020 at 11:59 PM Tom Lane wrote:
>
> Ashutosh Bapat writes:
> > On Mon, Oct 5, 2020 at 6:47 AM Tom Lane wrote:
> >> Now that I've seen this, I wonder whether add_child_join_rel_equivalences
> >> might not be making duplicate EC entries even without GEQO. Is there any
> >> guarant
Ashutosh Bapat writes:
> On Mon, Oct 5, 2020 at 6:47 AM Tom Lane wrote:
>> Now that I've seen this, I wonder whether add_child_join_rel_equivalences
>> might not be making duplicate EC entries even without GEQO. Is there any
>> guarantee that it's not called repeatedly on related join-rel sets?
On Mon, Oct 5, 2020 at 6:47 AM Tom Lane wrote:
>
> If you run the core regression tests with geqo_threshold = 2
> (injected, say, via ALTER SYSTEM SET), you will notice the
> earlier tests showing some join ordering differences, which
> is unsurprising ... but when it gets to partition_join, that
If you run the core regression tests with geqo_threshold = 2
(injected, say, via ALTER SYSTEM SET), you will notice the
earlier tests showing some join ordering differences, which
is unsurprising ... but when it gets to partition_join, that
test just dumps core.
Investigation shows that the crash
