Re: Parallel Append subplan order instability on aye-aye

2019-09-26 Thread Tom Lane
I wrote: > Yeah. I think we've had quite enough of the stats-transmission-related > failures, and they're no longer proving anything about the original > problem. So I will go do what I proposed in mid-July and revert the > stats queries, while keeping the reltuples/relpages check. (I'd kind > o

Re: Parallel Append subplan order instability on aye-aye

2019-08-11 Thread Tom Lane
Thomas Munro writes: > On Wed, Jul 24, 2019 at 11:59 AM Thomas Munro wrote: >> On Tue, Jul 16, 2019 at 12:21 PM Tom Lane wrote: >>> In the meantime, we've had *lots* of buildfarm failures in the >>> added pg_stat_all_tables query, which indicate that indeed the >>> stats collector mechanism isn'

Re: Parallel Append subplan order instability on aye-aye

2019-08-04 Thread Thomas Munro
On Wed, Jul 24, 2019 at 11:59 AM Thomas Munro wrote: > On Tue, Jul 16, 2019 at 12:21 PM Tom Lane wrote: > > In the meantime, we've had *lots* of buildfarm failures in the > > added pg_stat_all_tables query, which indicate that indeed the > > stats collector mechanism isn't terribly reliable. But

Re: Parallel Append subplan order instability on aye-aye

2019-07-23 Thread Thomas Munro
On Tue, Jul 16, 2019 at 12:21 PM Tom Lane wrote: > In the meantime, we've had *lots* of buildfarm failures in the > added pg_stat_all_tables query, which indicate that indeed the > stats collector mechanism isn't terribly reliable. But that > doesn't directly prove anything about the original pro

Re: Parallel Append subplan order instability on aye-aye

2019-07-17 Thread Tom Lane
Andres Freund writes: > On 2019-07-17 11:53:48 -0400, Tom Lane wrote: >> A brute-force way to fix this (or at least reduce the odds quite a bit) >> would be to have sanity_check.sql issue a CHECKPOINT before its VACUUM, >> thereby guaranteeing that none of these pages are still in need of being >>

Re: Parallel Append subplan order instability on aye-aye

2019-07-17 Thread Andres Freund
On 2019-07-17 11:53:48 -0400, Tom Lane wrote: > David Rowley writes: > > Surely it can't be that since that just sets what *pages gets set to. > > Tom mentioned that following was returning 0 pages and tuples: > > > -- Temporary hack to investigate whether extra vacuum/analyze is happening > > se

Re: Parallel Append subplan order instability on aye-aye

2019-07-17 Thread Tom Lane
David Rowley writes: > Surely it can't be that since that just sets what *pages gets set to. > Tom mentioned that following was returning 0 pages and tuples: > -- Temporary hack to investigate whether extra vacuum/analyze is happening > select relname, relpages, reltuples > from pg_class > where

Re: Parallel Append subplan order instability on aye-aye

2019-07-16 Thread David Rowley
On Wed, 17 Jul 2019 at 07:23, Andres Freund wrote: > > Hi, > > On 2019-07-15 21:12:32 -0400, Tom Lane wrote: > > But I bet that these tables forming > > an inheritance hierarchy (with multiple inheritance even) does > > have something to do with it somehow, because if this were a > > generic VACUU

Re: Parallel Append subplan order instability on aye-aye

2019-07-16 Thread Andres Freund
Hi, On 2019-07-15 21:12:32 -0400, Tom Lane wrote: > But I bet that these tables forming > an inheritance hierarchy (with multiple inheritance even) does > have something to do with it somehow, because if this were a > generic VACUUM bug surely we'd be seeing it elsewhere. It's possible that it's

Re: Parallel Append subplan order instability on aye-aye

2019-07-15 Thread Tom Lane
I wrote: > So that data-collection patch has been in place for nearly 2 months > (since 2019-05-21), and in that time we've seen a grand total of > no repeats of the original problem, as far as I've seen. Oh ... wait a minute. I decided to go scrape the buildfarm logs to confirm my impression tha

Re: Parallel Append subplan order instability on aye-aye

2019-07-15 Thread Tom Lane
[ reviving a thread that's been idle for awhile ] I wrote: > Thomas Munro writes: >> Huh, idiacanthus failed showing vacuum_count 0, in select_parallel. >> So ... the VACUUM command somehow skipped those tables? > No, because the reltuples counts are correct. I think what we're > looking at the

Re: Parallel Append subplan order instability on aye-aye

2019-06-04 Thread Noah Misch
On Mon, May 20, 2019 at 11:15:47PM -0400, Tom Lane wrote: > I got around to excavating in the buildfarm archives, and found a round > dozen of more-or-less-similar incidents. I went back 18 months, which > by coincidence (i.e., I didn't realize it till just now) is just about > the time since 624e

Re: Parallel Append subplan order instability on aye-aye

2019-05-21 Thread Tom Lane
Thomas Munro writes: > Huh, idiacanthus failed showing vacuum_count 0, in select_parallel. > So ... the VACUUM command somehow skipped those tables? No, because the reltuples counts are correct. I think what we're looking at there is the stats collector dropping a packet that told it about vacuu

Re: Parallel Append subplan order instability on aye-aye

2019-05-21 Thread Thomas Munro
On Wed, May 22, 2019 at 2:39 AM Tom Lane wrote: > David Rowley writes: > > I did add the following query just before the failing one and included > > the expected output from below. The tests pass for me in make check > > and the post-upgrade test passes in make check-world too. I guess we > >

Re: Parallel Append subplan order instability on aye-aye

2019-05-21 Thread Tom Lane
David Rowley writes: > I did add the following query just before the failing one and included > the expected output from below. The tests pass for me in make check > and the post-upgrade test passes in make check-world too. I guess we > could commit that and see if it fails along with the other

Re: Parallel Append subplan order instability on aye-aye

2019-05-20 Thread Tom Lane
Thomas Munro writes: > On Mon, May 20, 2019 at 4:46 PM Tom Lane wrote: >> Note that in the discussion that led up to 624e440a, we never did >> think that we'd completely explained the original irreproducible >> failure. >> >> I think I've seen a couple of other cases of this same failure >> in t

Re: Parallel Append subplan order instability on aye-aye

2019-05-20 Thread David Rowley
On Tue, 21 May 2019 at 11:32, Thomas Munro wrote: > > On Mon, May 20, 2019 at 4:46 PM Tom Lane wrote: > > Thomas Munro writes: > > > Here's a one-off regression test failure of a sort that commit > > > 624e440a intended to fix. > > > > Note that in the discussion that led up to 624e440a, we neve

Re: Parallel Append subplan order instability on aye-aye

2019-05-20 Thread Tom Lane
Thomas Munro writes: > On Mon, May 20, 2019 at 4:46 PM Tom Lane wrote: >> Note that in the discussion that led up to 624e440a, we never did >> think that we'd completely explained the original irreproducible >> failure. > I think it might be dependent on incidental vacuum/analyze activity > havi

Re: Parallel Append subplan order instability on aye-aye

2019-05-20 Thread Thomas Munro
On Mon, May 20, 2019 at 4:46 PM Tom Lane wrote: > Thomas Munro writes: > > Here's a one-off regression test failure of a sort that commit > > 624e440a intended to fix. > > Note that in the discussion that led up to 624e440a, we never did > think that we'd completely explained the original irrepro

Re: Parallel Append subplan order instability on aye-aye

2019-05-19 Thread Tom Lane
Thomas Munro writes: > Here's a one-off regression test failure of a sort that commit > 624e440a intended to fix. Note that in the discussion that led up to 624e440a, we never did think that we'd completely explained the original irreproducible failure. I think I've seen a couple of other cases

Parallel Append subplan order instability on aye-aye

2019-05-19 Thread Thomas Munro
Hi, Here's a one-off regression test failure of a sort that commit 624e440a intended to fix. a_star unexpectedly sorted higher. I checked the space weather forecast for this morning but no sign of solar flares. More seriously, it did the same in all 3 Parallel Append queries. Recent commits lo