Re: PATCH pass PGOPTIONS to pg_regress

2018-06-06 Thread Peter Eisentraut
On 5/29/18 09:19, Manuel Kniep wrote: > Consider something like this in an extensions makefile: > > ifeq ($(shell test $(VERSION_NUM) -ge 90600; echo $$?),0) > PGOPTIONS+= "--max_parallel_workers_per_gather=0" > endif I think you can probably write this inside your test .sql file using a bit of P

Re: PATCH pass PGOPTIONS to pg_regress

2018-06-04 Thread Manuel Kniep
> Am 30.05.2018 um 17:22 schrieb Michael Paquier : > > On Wed, May 30, 2018 at 12:28:27PM +0300, Ildar Musin wrote: >> Here extra.conf is implied to be a file in extension's root directory which >> contains additional server options. >> This would only work for `make check` though, not `make ins

Re: PATCH pass PGOPTIONS to pg_regress

2018-05-30 Thread Michael Paquier
On Wed, May 30, 2018 at 12:28:27PM +0300, Ildar Musin wrote: > Here extra.conf is implied to be a file in extension's root directory which > contains additional server options. > This would only work for `make check` though, not `make installcheck`. REGRESS_OPTS is more widely known for this purpo

Re: PATCH pass PGOPTIONS to pg_regress

2018-05-30 Thread Ildar Musin
Hi Manuel, On 29.05.2018 16:19, Manuel Kniep wrote: Hi, attached patch passes PGOPTIONS env variable to pg_regress in pgxs.mk This is especially useful when developing extensions for different postgres versions where some session_variables might or might not exists. Consider something like th

PATCH pass PGOPTIONS to pg_regress

2018-05-29 Thread Manuel Kniep
Hi, attached patch passes PGOPTIONS env variable to pg_regress in pgxs.mk This is especially useful when developing extensions for different postgres versions where some session_variables might or might not exists. Consider something like this in an extensions makefile: ifeq ($(shell test $(VE