On Mon, Sep 24, 2018 at 05:36:39PM -0400, Tom Lane wrote:
> I reviewed and pushed this.
Great! Thank you.
> As a cross-check on the patch, I cloned the Snowball github repo
> and built the derived files in it. I noticed that they'd incorporated
> several new stemmers since 2007 --- not only your
Arthur Zakirov writes:
> Ah, I see. I attached new version made with --no-renames. Will wait for
> what cfbot will say.
I reviewed and pushed this.
As a cross-check on the patch, I cloned the Snowball github repo
and built the derived files in it. I noticed that they'd incorporated
several new
Arthur Zakirov writes:
> On Wed, Sep 12, 2018 at 04:03:57PM -0400, Tom Lane wrote:
>> Did you miss including Makefile changes in the submitted patch?
> I've noticed the error some time ago. And I tried to understand why
> cfbot can't build it. Somehow cfbot didn't rename
> stem_ISO_8859_1_hungari
On Wed, Sep 12, 2018 at 04:03:57PM -0400, Tom Lane wrote:
> I see that the cfbot is having difficulty building this:
>
> make[2]: *** No rule to make target `stem_ISO_8859_2_hungarian.o', needed by
> `dict_snowball.so'. Stop.
>
> Did you miss including Makefile changes in the submitted patch?
I see that the cfbot is having difficulty building this:
make[2]: *** No rule to make target `stem_ISO_8859_2_hungarian.o', needed by
`dict_snowball.so'. Stop.
Did you miss including Makefile changes in the submitted patch?
regards, tom lane
On Fri, Jul 06, 2018 at 12:37:26PM -0400, Tom Lane wrote:
> > I don't know if we have a buildfarm animal testing Hungarian. Maybe we
> > need a buildfarm animal or two testing a large number of locales.
>
> I dunno that we need to set up a permanent buildfarm member for this.
> I had been thinkin
Andrew Dunstan writes:
> On 06/26/2018 08:20 AM, Arthur Zakirov wrote:
>> I'd like to propose the patch which syncs PostgreSQL snowball stemmers.
>> As Tom pointed [1] stemmers haven't synced for a very long time.
> I agree with Tom that we should sync with the upstream before we do
> anything e
On 06/26/2018 08:20 AM, Arthur Zakirov wrote:
Hello hackers,
I'd like to propose the patch which syncs PostgreSQL snowball stemmers.
As Tom pointed [1] stemmers haven't synced for a very long time.
I copied all source files without changes, except replacing '#include
"../runtime/header.h"' w
