Re: PANIC: could not fsync file "pg_multixact/..." since commit dee663f7843

2020-11-04 Thread Thomas Munro
On Thu, Nov 5, 2020 at 12:07 PM Tomas Vondra wrote: > It's been running for hours on both machines, without any crashes etc. > While that's not a definitive proof the fix is correct, it certainly > behaves differently. Thanks! Embarrassed to have missed that. Pushed.

Re: PANIC: could not fsync file "pg_multixact/..." since commit dee663f7843

2020-11-04 Thread Tomas Vondra
On 11/4/20 2:50 PM, Tomas Vondra wrote: On Wed, Nov 04, 2020 at 05:36:46PM +1300, Thomas Munro wrote: On Wed, Nov 4, 2020 at 2:57 PM Tomas Vondra wrote: On Wed, Nov 04, 2020 at 02:49:24PM +1300, Thomas Munro wrote: >On Wed, Nov 4, 2020 at 2:32 PM Tomas Vondra > wrote: >> After a while (~1h on

Re: PANIC: could not fsync file "pg_multixact/..." since commit dee663f7843

2020-11-04 Thread Tomas Vondra
On Wed, Nov 04, 2020 at 05:36:46PM +1300, Thomas Munro wrote: On Wed, Nov 4, 2020 at 2:57 PM Tomas Vondra wrote: On Wed, Nov 04, 2020 at 02:49:24PM +1300, Thomas Munro wrote: >On Wed, Nov 4, 2020 at 2:32 PM Tomas Vondra > wrote: >> After a while (~1h on my machine) the pg_multixact gets over 10

Re: PANIC: could not fsync file "pg_multixact/..." since commit dee663f7843

2020-11-03 Thread Thomas Munro
On Wed, Nov 4, 2020 at 2:57 PM Tomas Vondra wrote: > On Wed, Nov 04, 2020 at 02:49:24PM +1300, Thomas Munro wrote: > >On Wed, Nov 4, 2020 at 2:32 PM Tomas Vondra > > wrote: > >> After a while (~1h on my machine) the pg_multixact gets over 10GB, which > >> triggers a more aggressive cleanup (per Mu

Re: PANIC: could not fsync file "pg_multixact/..." since commit dee663f7843

2020-11-03 Thread Tomas Vondra
On Wed, Nov 04, 2020 at 02:49:24PM +1300, Thomas Munro wrote: On Wed, Nov 4, 2020 at 2:32 PM Tomas Vondra wrote: After a while (~1h on my machine) the pg_multixact gets over 10GB, which triggers a more aggressive cleanup (per MultiXactMemberFreezeThreshold). My guess is that this discards some

Re: PANIC: could not fsync file "pg_multixact/..." since commit dee663f7843

2020-11-03 Thread Thomas Munro
On Wed, Nov 4, 2020 at 2:32 PM Tomas Vondra wrote: > After a while (~1h on my machine) the pg_multixact gets over 10GB, which > triggers a more aggressive cleanup (per MultiXactMemberFreezeThreshold). > My guess is that this discards some of the files, but checkpointer is > not aware of that, or s

PANIC: could not fsync file "pg_multixact/..." since commit dee663f7843

2020-11-03 Thread Tomas Vondra
Hi, While running some multixact-oriented stress tests, I noticed that commit dee663f7843: Defer flushing of SLRU files. Previously, we called fsync() after writing out individual pg_xact, pg_multixact and pg_commit_ts pages due to cache pressure, leading to regular I/O stalls i