Re: Outdated comments about proc->sem in lwlock.c

2021-07-08 Thread Thomas Munro
On Thu, Jul 8, 2021 at 8:48 AM Daniel Gustafsson wrote: > > On 3 Jun 2021, at 04:07, Thomas Munro wrote: > > Here's a patch to remove the misleading comments. > > While not an expert in the area; reading the referenced commit and the code > with the now removed comments, I think this is correct.

Re: Outdated comments about proc->sem in lwlock.c

2021-07-07 Thread Daniel Gustafsson
> On 3 Jun 2021, at 04:07, Thomas Munro wrote: > Here's a patch to remove the misleading comments. While not an expert in the area; reading the referenced commit and the code with the now removed comments, I think this is correct. -- Daniel Gustafsson https://vmware.com/

Re: Outdated comments about proc->sem in lwlock.c

2021-06-02 Thread Thomas Munro
On Wed, Mar 10, 2021 at 1:11 AM Thomas Munro wrote: > In passing I noticed that lwlock.c contains 3 comments about bogus > wakeups due to sharing proc->sem with the heavyweight lock manager and > ProcWaitForSignal. Commit 675f55e (9.5) switched those things > from proc->sem to proc->procLatch

Outdated comments about proc->sem in lwlock.c

2021-03-09 Thread Thomas Munro
Hi, In passing I noticed that lwlock.c contains 3 comments about bogus wakeups due to sharing proc->sem with the heavyweight lock manager and ProcWaitForSignal. Commit 675f55e (9.5) switched those things from proc->sem to proc->procLatch. ProcArrayGroupClearXid() and TransactionGroupUpdateXi