Re: Out arguments name of "pg_identify_object_as_address" function in 9.5.14 and 11beta3

2018-09-05 Thread Alvaro Herrera
On 2018-Sep-05, Tom Lane wrote: > Alvaro Herrera writes: > > That said, I haven't heard of anyone using these functions in code yet, > > so if we change it in 11 or 12 nobody is going to complain. > > ... and that's pretty much my feeling. It seems really unlikely that > anyone's using named-a

Re: Out arguments name of "pg_identify_object_as_address" function in 9.5.14 and 11beta3

2018-09-05 Thread Tom Lane
Alvaro Herrera writes: > On 2018-Sep-03, Tom Lane wrote: >> I do not think we can change the names of the output arguments; >> it'd break existing queries. However, renaming input arguments >> shouldn't affect anything. So I propose we make pg_get_object_address' >> input arguments be named type

Re: Out arguments name of "pg_identify_object_as_address" function in 9.5.14 and 11beta3

2018-09-03 Thread Alvaro Herrera
On 2018-Sep-03, Tom Lane wrote: > Jean-Pierre Pelletier writes: > > Two of the out arguments name of function > > "pg_identify_object_as_address" are not as documented. > > Documentation says "name" and "args", but function returns > > "object_names" and "object_args". > > Hm, yeah. The documen

Re: Out arguments name of "pg_identify_object_as_address" function in 9.5.14 and 11beta3

2018-09-03 Thread Tom Lane
Andrew Gierth writes: > "Tom" == Tom Lane writes: > Tom> I do not think we can change the names of the output arguments; > Tom> it'd break existing queries. However, renaming input arguments > Tom> shouldn't affect anything. > What about callers that might be using named-argument notation? O

Re: Out arguments name of "pg_identify_object_as_address" function in 9.5.14 and 11beta3

2018-09-03 Thread Andrew Gierth
> "Tom" == Tom Lane writes: Tom> I do not think we can change the names of the output arguments; Tom> it'd break existing queries. However, renaming input arguments Tom> shouldn't affect anything. What about callers that might be using named-argument notation? -- Andrew (irc:RhodiumToad

Re: Out arguments name of "pg_identify_object_as_address" function in 9.5.14 and 11beta3

2018-09-03 Thread Tom Lane
Jean-Pierre Pelletier writes: > Two of the out arguments name of function > "pg_identify_object_as_address" are not as documented. > Documentation says "name" and "args", but function returns > "object_names" and "object_args". Hm, yeah. The documentation of pg_get_object_address() seems equally

Out arguments name of "pg_identify_object_as_address" function in 9.5.14 and 11beta3

2018-09-03 Thread Jean-Pierre Pelletier
Two of the out arguments name of function "pg_identify_object_as_address" are not as documented. Documentation says "name" and "args", but function returns "object_names" and "object_args". This query shows what the function returns: select (pg_identify_object_as_address(classId, ObjId, objSubId))