Re: Out-of-tree certificate interferes ssltest

2022-03-21 Thread Michael Paquier
On Fri, Mar 18, 2022 at 06:15:28PM -0400, Andrew Dunstan wrote: > On 3/17/22 21:02, Michael Paquier wrote: >> Another thing that Horiguchi-san has pointed out upthread (?) is 003, >> where it is also possible to trigger failures once the environment is >> hijacked. The attached allows the full tes

Re: Out-of-tree certificate interferes ssltest

2022-03-18 Thread Andrew Dunstan
On 3/17/22 21:02, Michael Paquier wrote: > On Thu, Mar 17, 2022 at 02:28:49PM +0100, Daniel Gustafsson wrote: >> One small concern though. This hunk: >> >> +my $default_ssl_connstr = "sslkey=invalid sslcert=invalid >> sslrootcert=invalid sslcrl=invalid sslcrldir=invalid"; >> + >> $common_connst

Re: Out-of-tree certificate interferes ssltest

2022-03-17 Thread Michael Paquier
On Thu, Mar 17, 2022 at 02:28:49PM +0100, Daniel Gustafsson wrote: > One small concern though. This hunk: > > +my $default_ssl_connstr = "sslkey=invalid sslcert=invalid > sslrootcert=invalid sslcrl=invalid sslcrldir=invalid"; > + > $common_connstr = > - "user=ssltestuser dbname=trustdb sslcert=

Re: Out-of-tree certificate interferes ssltest

2022-03-17 Thread Daniel Gustafsson
> On 17 Mar 2022, at 09:05, Kyotaro Horiguchi wrote: > > At Thu, 17 Mar 2022 16:22:14 +0900, Michael Paquier > wrote in >> On Thu, Mar 17, 2022 at 02:59:26PM +0900, Michael Paquier wrote: >>> In both cases, enforcing sslcrl to a value of "invalid" interferes >>> with the failure scenario we ex

Re: Out-of-tree certificate interferes ssltest

2022-03-17 Thread Kyotaro Horiguchi
At Thu, 17 Mar 2022 16:22:14 +0900, Michael Paquier wrote in > On Thu, Mar 17, 2022 at 02:59:26PM +0900, Michael Paquier wrote: > > In both cases, enforcing sslcrl to a value of "invalid" interferes > > with the failure scenario we expect from sslcrldir. It is possible to > > bypass that with s

Re: Out-of-tree certificate interferes ssltest

2022-03-17 Thread Michael Paquier
On Thu, Mar 17, 2022 at 02:59:26PM +0900, Michael Paquier wrote: > In both cases, enforcing sslcrl to a value of "invalid" interferes > with the failure scenario we expect from sslcrldir. It is possible to > bypass that with something like the attached, but that's a kind of > ugly hack. Another a

Re: Out-of-tree certificate interferes ssltest

2022-03-16 Thread Michael Paquier
On Wed, Mar 16, 2022 at 11:45:39AM +0100, Daniel Gustafsson wrote: > On 16 Mar 2022, at 08:36, Kyotaro Horiguchi wrote: >> The attached fixes that and make-world successfully finished even if I >> have a cert file in my home direcotory. > > Seems correct to me, thanks! The ultimate test I can th

Re: Out-of-tree certificate interferes ssltest

2022-03-16 Thread Daniel Gustafsson
> On 16 Mar 2022, at 08:36, Kyotaro Horiguchi wrote: > I think we don't want this behavior. Agreed. > The attached fixes that and make-world successfully finished even if I > have a cert file in my home direcotory. Seems correct to me, thanks! -- Daniel Gustafsson https://vmware

Re: Out-of-tree certificate interferes ssltest

2022-03-16 Thread Michael Paquier
On Wed, Mar 16, 2022 at 04:36:58PM +0900, Kyotaro Horiguchi wrote: > ok 6 - ssl_client_cert_present() for connection with cert > connection error: 'psql: error: connection to server at "127.0.0.1", port > 61688 failed: could not read certificate file > "/home/horiguti/.postgresql/postgresql.crt":

Out-of-tree certificate interferes ssltest

2022-03-16 Thread Kyotaro Horiguchi
Hello. 003_sslinfo.pl fails for me. ok 6 - ssl_client_cert_present() for connection with cert connection error: 'psql: error: connection to server at "127.0.0.1", port 61688 failed: could not read certificate file "/home/horiguti/.postgresql/postgresql.crt": no start line' while running 'psql -