On Fri, Jun 28, 2019 at 1:02 AM Tomas Vondra
wrote:
> On Thu, Jun 27, 2019 at 01:53:52PM +0200, Daniel Gustafsson wrote:
> >> On 27 Jun 2019, at 13:05, Etsuro Fujita wrote:
> >
> >> since the citation was also moved to
> >> utils/misc/sampling.c, I think the "see full citation below" part
> >> sh
On Thu, Jun 27, 2019 at 01:53:52PM +0200, Daniel Gustafsson wrote:
On 27 Jun 2019, at 13:05, Etsuro Fujita wrote:
since the citation was also moved to
utils/misc/sampling.c, I think the "see full citation below" part
should be updated accordingly. Attached is a patch for that.
Agreed, nice
> On 27 Jun 2019, at 13:05, Etsuro Fujita wrote:
> since the citation was also moved to
> utils/misc/sampling.c, I think the "see full citation below" part
> should be updated accordingly. Attached is a patch for that.
Agreed, nice catch!
cheers ./daniel
Hi,
I think commit 83e176ec1, which moved block sampling functions to
utils/misc/sampling.c, forgot to update this comment in
commands/analyze.c: "This algorithm is from Jeff Vitter's paper (see
full citation below)"; since the citation was also moved to
utils/misc/sampling.c, I think the "see ful