Andres Freund writes:
> On 2021-05-09 18:17:36 -0400, Tom Lane wrote:
>> Proposed comment patch attached.
> lgtm.
Pushed, thanks.
regards, tom lane
On 2021-05-09 18:17:36 -0400, Tom Lane wrote:
> Proposed comment patch attached.
lgtm.
Andres Freund writes:
> On 2021-05-09 17:12:14 -0400, Tom Lane wrote:
>> (I wonder if we shouldn't adjust the comments in pg_config_manual.h,
>> though, as they certainly leave the impression that USE_VALGRIND
>> isn't essential.)
> That'd make sense to me. If we found a better way to deal with t
Hi,
On 2021-05-09 17:12:14 -0400, Tom Lane wrote:
> (I wonder if we shouldn't adjust the comments in pg_config_manual.h,
> though, as they certainly leave the impression that USE_VALGRIND
> isn't essential.)
That'd make sense to me. If we found a better way to deal with the
sinval thing it'd be g
Andres Freund writes:
> On 2021-05-09 15:29:06 -0400, Tom Lane wrote:
>> One point worth mentioning is that I'd forgotten to build with
>> "#define USE_VALGRIND" in the first try. AFAIK that should make
>> valgrind strictly less sensitive, so I think it's not material,
>> but still.
> I think it
Hi,
On 2021-05-09 15:29:06 -0400, Tom Lane wrote:
> I happened to be trying to run the core regression tests under
> valgrind, and I got the complaints attached below, from the
> process that had been running the insert_conflict test script.
>
> I could not reproduce the failure in a second run, w
I happened to be trying to run the core regression tests under
valgrind, and I got the complaints attached below, from the
process that had been running the insert_conflict test script.
I could not reproduce the failure in a second run, which is not
hugely surprising because it appears to be in cr
