Re: New string-truncation warnings from GCC 15

2025-09-17 Thread Andres Freund
Hi, On 2025-09-17 17:26:50 -0400, Tom Lane wrote: > Andres Freund writes: > > On 2025-09-17 17:00:42 -0400, Tom Lane wrote: > >> Well, we should either commit to it (and put -Wextra into our > >> standard switches) or not. > > > I'd be mildly worried about -Wextra in older compilers (and clang, b

Re: New string-truncation warnings from GCC 15

2025-09-17 Thread Tom Lane
Andres Freund writes: > On 2025-09-17 17:00:42 -0400, Tom Lane wrote: >> Well, we should either commit to it (and put -Wextra into our >> standard switches) or not. > I'd be mildly worried about -Wextra in older compilers (and clang, but just > because I don't regularly track -Wextra with clang).

Re: New string-truncation warnings from GCC 15

2025-09-17 Thread Andres Freund
On 2025-09-17 17:00:42 -0400, Tom Lane wrote: > Andres Freund writes: > > On 2025-09-17 16:38:56 -0400, Tom Lane wrote: > >> Oh! Hmm... I am not sure that we want to commit to being -Wextra > >> clean across-the-board. > > > We've been -Wextra clean for years, with a few temporary exceptions. IM

Re: New string-truncation warnings from GCC 15

2025-09-17 Thread Tom Lane
Andres Freund writes: > On 2025-09-17 16:38:56 -0400, Tom Lane wrote: >> Oh! Hmm... I am not sure that we want to commit to being -Wextra >> clean across-the-board. > We've been -Wextra clean for years, with a few temporary exceptions. IME a lot > of warnings added to -Wextra in one year, get pr

Re: New string-truncation warnings from GCC 15

2025-09-17 Thread Andres Freund
Hi, On 2025-09-17 16:38:56 -0400, Tom Lane wrote: > Peter Eisentraut writes: > > On 17.09.25 00:48, Tom Lane wrote: > >> Several of the buildfarm animals seem to have been updated to > >> GCC 15 over the past week or so. They are now moaning about > >> various places where we're intentionally om

Re: New string-truncation warnings from GCC 15

2025-09-17 Thread Tom Lane
Peter Eisentraut writes: > On 17.09.25 00:48, Tom Lane wrote: >> Several of the buildfarm animals seem to have been updated to >> GCC 15 over the past week or so. They are now moaning about >> various places where we're intentionally omitting a string >> terminator, eg these warnings from scorpio

Re: New string-truncation warnings from GCC 15

2025-09-17 Thread Peter Eisentraut
On 17.09.25 00:48, Tom Lane wrote: Several of the buildfarm animals seem to have been updated to GCC 15 over the past week or so. They are now moaning about various places where we're intentionally omitting a string terminator, eg these warnings from scorpion: scorpion | 2025-09-16 18:39

New string-truncation warnings from GCC 15

2025-09-17 Thread Tom Lane
Several of the buildfarm animals seem to have been updated to GCC 15 over the past week or so. They are now moaning about various places where we're intentionally omitting a string terminator, eg these warnings from scorpion: scorpion | 2025-09-16 18:39:03 | ../pgsql/src/backend/commands/c

Re: New string-truncation warnings from GCC 15

2025-09-16 Thread Andres Freund
Hi, On 2025-09-16 18:48:07 -0400, Tom Lane wrote: > Several of the buildfarm animals seem to have been updated to > GCC 15 over the past week or so. They are now moaning about > various places where we're intentionally omitting a string > terminator, eg these warnings from scorpion: > > scorpio

Re: New string-truncation warnings from GCC 15

2025-09-16 Thread Tom Lane
Andres Freund writes: > On 2025-09-16 18:48:07 -0400, Tom Lane wrote: >> It's not clear to me how well this approach will play with >> non-GCC compilers. > I'd assume we'd do something like > #if has_attribute(nonstring) > #define pg_nonstring __attribute__((nonstring)) > #else > ... > #define p