Re: NLS handling fixes.

2018-08-20 Thread Michael Paquier
On Tue, Aug 21, 2018 at 11:49:05AM +0900, Kyotaro HORIGUCHI wrote: > Agreed on all of the above, but if we don't need translation in > the header line of \gdesc, gettext_noop for the strings is > useless. I have let that one alone, as all columns showing up in psql have the same, consistent way of

Re: NLS handling fixes.

2018-08-20 Thread Kyotaro HORIGUCHI
At Mon, 20 Aug 2018 13:23:38 +0900, Michael Paquier wrote in <20180820042338.gh7...@paquier.xyz> > On Fri, Aug 10, 2018 at 04:50:55PM -0400, Tom Lane wrote: > > I would certainly *not* back-patch the GetConfigOptionByNum change, > > as that will be a user-visible behavioral change that people wil

Re: NLS handling fixes.

2018-08-19 Thread Michael Paquier
On Fri, Aug 10, 2018 at 04:50:55PM -0400, Tom Lane wrote: > I would certainly *not* back-patch the GetConfigOptionByNum change, > as that will be a user-visible behavioral change that people will > not be expecting. We might get away with back-patching the other changes, > but SHOW ALL output seem

Re: NLS handling fixes.

2018-08-10 Thread Tom Lane
Michael Paquier writes: > I have been looking at all the things you are proposing here, and it > seems to me that you are right for these. I lack a bit of knowledge > about the translation of items, but can such things be back-patched? I would certainly *not* back-patch the GetConfigOptionByNum

Re: NLS handling fixes.

2018-08-10 Thread Alvaro Herrera
On 2018-Aug-10, Michael Paquier wrote: > On Fri, Aug 10, 2018 at 03:21:31PM +0900, Kyotaro HORIGUCHI wrote: > > The cause is GetConfigOptionByNum is forgetting to retrieve > > translations for texts that have been marked with gettext_noop. > > > > Regarding GUCs, group names, short desc and long d

Re: NLS handling fixes.

2018-08-10 Thread Michael Paquier
On Fri, Aug 10, 2018 at 03:21:31PM +0900, Kyotaro HORIGUCHI wrote: > The cause is GetConfigOptionByNum is forgetting to retrieve > translations for texts that have been marked with gettext_noop. > > Regarding GUCs, group names, short desc and long desc have > translations so the attached first patc

NLS handling fixes.

2018-08-09 Thread Kyotaro HORIGUCHI
Hello. I found that backend's .po file has lines for GUC descriptions but we won't see them anywhere. The cause is GetConfigOptionByNum is fogetting to retrieve translations for texts that have been marked with gettext_noop. Regarding GUCs, group names, short desc and long desc have translations