Re: Multiple pg_waldump --rmgr options

2021-06-30 Thread Daniel Gustafsson
> On 30 Jun 2021, at 22:39, Heikki Linnakangas wrote: > In general, I think it's weird that the latest option wins. If you specify > the same option multiple times, and it's not something like --rmgr or --table > where it makes sense, it's most likely user error. Printing an error would be > n

Re: Multiple pg_waldump --rmgr options

2021-06-30 Thread Heikki Linnakangas
On 28/06/2021 13:34, Daniel Gustafsson wrote: On 18 May 2021, at 15:50, Heikki Linnakangas wrote: The reason is that if you specify multiple --rmgr options, only the last one takes effect. That's in line with how options are handled for most binaries, so this will go against that. That be

Re: Multiple pg_waldump --rmgr options

2021-06-28 Thread Daniel Gustafsson
> On 18 May 2021, at 15:50, Heikki Linnakangas wrote: > The reason is that if you specify multiple --rmgr options, only the last one > takes effect. That's in line with how options are handled for most binaries, so this will go against that. That being said, I don't think thats a problem here

Re: Multiple pg_waldump --rmgr options

2021-05-18 Thread Michael Paquier
On Wed, May 19, 2021 at 11:50:52AM +0900, Kyotaro Horiguchi wrote: > At Tue, 18 May 2021 23:23:02 +0800, Julien Rouhaud wrote > in >> The change and the patch look sensible to me. > > +1. Agreed. -- Michael signature.asc Description: PGP signature

Re: Multiple pg_waldump --rmgr options

2021-05-18 Thread Kyotaro Horiguchi
At Tue, 18 May 2021 23:23:02 +0800, Julien Rouhaud wrote in > On Tue, May 18, 2021 at 04:50:31PM +0300, Heikki Linnakangas wrote: > > That didn't do what I wanted. It only printed the Heap2 records, not Heap, > > even though I specified both. The reason is that if you specify multiple > > --rmgr

Re: Multiple pg_waldump --rmgr options

2021-05-18 Thread Julien Rouhaud
On Tue, May 18, 2021 at 04:50:31PM +0300, Heikki Linnakangas wrote: > I wanted to dump all heap WAL records with pg_waldump, so I did this: > > > $ pg_waldump --rmgr=heap --rmgr=heap2 data/pg_wal/00010001 > > --stat=record > > Type N

Multiple pg_waldump --rmgr options

2021-05-18 Thread Heikki Linnakangas
I wanted to dump all heap WAL records with pg_waldump, so I did this: $ pg_waldump --rmgr=heap --rmgr=heap2 data/pg_wal/00010001 --stat=record Type N (%) Record size (%) FPI size (%)Combined s