Re: Multiple Wait Events for extensions

2018-10-28 Thread Michael Paquier
On Sun, Oct 28, 2018 at 10:12:48AM -0700, legrand legrand wrote: > An other idea that may be called a "better wait event error handling" > would have be to display: > > "???-xx" unknown event type (xx being the associated number) > in pgstat_get_wait_event_type() > > "unknown wait event - yy" un

Re: Multiple Wait Events for extensions

2018-10-28 Thread legrand legrand
Michael Paquier-2 wrote > On Wed, Oct 24, 2018 at 11:18:13AM -0700, legrand legrand wrote: >> Would a hard coded solution as described here after possible for >> mid-term? > > I don't think I would commit that as we would want a better solution > with custom names, but patching Postgres to do so w

Re: Multiple Wait Events for extensions

2018-10-28 Thread legrand legrand
Michael Paquier-2 wrote > On Wed, Oct 24, 2018 at 11:18:13AM -0700, legrand legrand wrote: >> Would a hard coded solution as described here after possible for >> mid-term? > > I don't think I would commit that as we would want a better solution > with custom names, but patching Postgres to do so w

Re: Multiple Wait Events for extensions

2018-10-24 Thread Michael Paquier
On Wed, Oct 24, 2018 at 11:18:13AM -0700, legrand legrand wrote: > Would a hard coded solution as described here after possible for > mid-term? I don't think I would commit that as we would want a better solution with custom names, but patching Postgres to do so with a custom build would be easy e

Re: Multiple Wait Events for extensions

2018-10-24 Thread legrand legrand
Would a hard coded solution as described here after possible for mid-term ? note: actual result from pgstat_report_wait_star(PG_WAIT_EXTENSION); is preserved. Regards PAscal pgstat.h /* -- * Wait Events - Extension * * Use this category when an extension is waiting. * -

Re: Multiple Wait Events for extensions

2018-10-22 Thread Michael Paquier
On Mon, Oct 22, 2018 at 10:28:14AM -0700, legrand legrand wrote: > Could this be changed to offer an extension the ability to log multiple > events and many extensions to work together? I recall that this issue has been discussed when adding new wait events, and we discarded it for simplicity as t

Multiple Wait Events for extensions

2018-10-22 Thread legrand legrand
Hello, I'm playing with adding into my pg_stat_statements extension a wait event for pgss time duration (pgss_store) Adding pgstat_report_wait_start(PG_WAIT_EXTENSION) gives wait type = "Extension" / event name "Extension" and that's perfect. Now I would like to add a second wait event (for exe