Re: Move tests of contrib/spi/ out of the core regression tests

2025-04-08 Thread Tom Lane
Heikki Linnakangas writes: > On 08/04/2025 16:55, Tom Lane wrote: >> + The trigger will replace the field's value only if that value is >> + initially zero or null (after the action of the SQL statement that >> + inserted or updated the row). Also, if the sequence's next value is >> + zer

Re: Move tests of contrib/spi/ out of the core regression tests

2025-04-08 Thread Heikki Linnakangas
On 08/04/2025 16:55, Tom Lane wrote: Well, I don't mind pushing it, but does anyone want to review it first? It sounded like Heikki had at least eyeballed the patch, but I'm not sure if he's ready to sign off on it. It looks good to me. diff --git a/doc/src/sgml/contrib-spi.sgml b/doc/src/sg

Re: Move tests of contrib/spi/ out of the core regression tests

2025-04-08 Thread Tom Lane
Andrew Dunstan writes: > On 2025-04-08 Tu 5:21 AM, Heikki Linnakangas wrote: >>> This is too late for v18 of course, so I'll park it in the next CF. >> In my opinion this would still be totally OK for v18. It's just test >> changes. I would rather commit cleanups like this sooner than later. >

Re: Move tests of contrib/spi/ out of the core regression tests

2025-04-08 Thread Andrew Dunstan
On 2025-04-08 Tu 5:21 AM, Heikki Linnakangas wrote: This is too late for v18 of course, so I'll park it in the next CF. In my opinion this would still be totally OK for v18. It's just test changes. I would rather commit cleanups like this sooner than later. Yeah, that was my reaction t

Re: Move tests of contrib/spi/ out of the core regression tests

2025-04-08 Thread wenhui qiu
Hi > This is too late for v18 of course, so I'll park it in the next CF. > In my opinion this would still be totally OK for v18. It's just test > changes. I would rather commit cleanups like this sooner than later. Agree +1 On Tue, Apr 8, 2025 at 5:22 PM Heikki Linnakangas wrote: > On 08/04/202

Re: Move tests of contrib/spi/ out of the core regression tests

2025-04-08 Thread Heikki Linnakangas
On 08/04/2025 04:59, Tom Lane wrote: The attached patch removes test cases concerned with contrib/spi/ from the core regression tests and instead puts them into new test files in contrib/spi/ itself. +1 My original motivation for looking at this was the discussion in [1] about whether to remo

Move tests of contrib/spi/ out of the core regression tests

2025-04-07 Thread Tom Lane
The attached patch removes test cases concerned with contrib/spi/ from the core regression tests and instead puts them into new test files in contrib/spi/ itself. My original motivation for looking at this was the discussion in [1] about whether to remove contrib/spi/refint.c entirely, since it's