Re: Move regression.diffs of pg_upgrade test suite

2019-05-19 Thread Noah Misch
On Sun, Dec 30, 2018 at 11:28:56AM -0500, Noah Misch wrote: > On Sun, Dec 30, 2018 at 10:41:46AM -0500, Andrew Dunstan wrote: > > On 12/26/18 5:44 PM, Noah Misch wrote: > > > On Wed, Dec 26, 2018 at 05:02:37PM -0500, Tom Lane wrote: > > >> Andrew Dunstan writes: > > >>> On 12/23/18 10:44 PM, Noah

Re: Move regression.diffs of pg_upgrade test suite

2018-12-30 Thread Noah Misch
On Sun, Dec 30, 2018 at 10:41:46AM -0500, Andrew Dunstan wrote: > On 12/26/18 5:44 PM, Noah Misch wrote: > > On Wed, Dec 26, 2018 at 05:02:37PM -0500, Tom Lane wrote: > >> Andrew Dunstan writes: > >>> On 12/23/18 10:44 PM, Noah Misch wrote: > A disadvantage of any change here is that it degra

Re: Move regression.diffs of pg_upgrade test suite

2018-12-30 Thread Andrew Dunstan
On 12/26/18 5:44 PM, Noah Misch wrote: > On Wed, Dec 26, 2018 at 05:02:37PM -0500, Tom Lane wrote: >> Andrew Dunstan writes: >>> On 12/23/18 10:44 PM, Noah Misch wrote: A disadvantage of any change here is that it degrades buildfarm reports, which recover slowly as owners upgrade

Re: Move regression.diffs of pg_upgrade test suite

2018-12-26 Thread Noah Misch
On Wed, Dec 26, 2018 at 05:02:37PM -0500, Tom Lane wrote: > Andrew Dunstan writes: > > On 12/23/18 10:44 PM, Noah Misch wrote: > >> A disadvantage of any change here is that it degrades buildfarm reports, > >> which > >> recover slowly as owners upgrade to a fixed buildfarm release. This will >

Re: Move regression.diffs of pg_upgrade test suite

2018-12-26 Thread Tom Lane
Andrew Dunstan writes: > On 12/23/18 10:44 PM, Noah Misch wrote: >> A disadvantage of any change here is that it degrades buildfarm reports, >> which >> recover slowly as owners upgrade to a fixed buildfarm release. This will be >> similar to the introduction of --outputdir=output_iso. On non-u

Re: Move regression.diffs of pg_upgrade test suite

2018-12-24 Thread Andrew Dunstan
On 12/23/18 10:44 PM, Noah Misch wrote: > src/bin/pg_upgrade/test.sh runs installcheck, which writes to files in > src/test/regress. This has at least two disadvantages when check-world runs > both this test suite and the "make check" suite: > > 1. The suite finishing second will overwrite the o

Move regression.diffs of pg_upgrade test suite

2018-12-23 Thread Noah Misch
src/bin/pg_upgrade/test.sh runs installcheck, which writes to files in src/test/regress. This has at least two disadvantages when check-world runs both this test suite and the "make check" suite: 1. The suite finishing second will overwrite the other's regression.{out,diffs}. 2. If these suites r