On 2020-11-05 12:59, John Naylor wrote:
And yes, this doesn't materially change the patch, it's just nitpicking
:-) . Materially, I believe it's fine.
OK, committed.
--
Peter Eisentraut
2ndQuadrant, an EDB company
https://www.2ndquadrant.com/
On Thu, Nov 5, 2020 at 2:20 PM Peter Eisentraut <
peter.eisentr...@2ndquadrant.com> wrote:
> On 2020-11-05 12:59, John Naylor wrote:
> > I think we're talking past eachother. Here's a concrete example:
> >
> > #define BKI_ROWTYPE_OID(oid,oidmacro)
> > #define DECLARE_TOAST(name,toastoid,indexoid)
On 2020-11-05 12:59, John Naylor wrote:
I think we're talking past eachother. Here's a concrete example:
#define BKI_ROWTYPE_OID(oid,oidmacro)
#define DECLARE_TOAST(name,toastoid,indexoid) extern int no_such_variable
I understand these to be functionally equivalent as far as what the C
compile
On Thu, Nov 5, 2020 at 4:24 AM Peter Eisentraut <
peter.eisentr...@2ndquadrant.com> wrote:
> On 2020-10-27 13:12, John Naylor wrote:
> > There's nothing wrong; it's just a minor point of consistency. For the
> > first part, I mean defined symbols in this file that are invisible to
> > the C compil
On 2020-10-27 13:12, John Naylor wrote:
There's nothing wrong; it's just a minor point of consistency. For the
first part, I mean defined symbols in this file that are invisible to
the C compiler are written
#define SOMETHING()
If some are written
#define SOMETHING() extern int no_such_varia
On Tue, Oct 27, 2020 at 7:43 AM Peter Eisentraut <
peter.eisentr...@2ndquadrant.com> wrote:
> On 2020-10-24 15:23, John Naylor wrote:
> > Style: In genbki.h, "extern int no_such_variable" is now out of place.
> > Also, the old comments like "The macro definitions are just to keep the
> > C compile
On 2020-10-24 15:23, John Naylor wrote:
This part created a syntax error:
--- a/src/include/catalog/unused_oids
+++ b/src/include/catalog/unused_oids
@@ -28,7 +28,7 @@ chdir $FindBin::RealBin or die "could not cd to
$FindBin::RealBin: $!\n";
use lib "$FindBin::RealBin/../../backend/catalog/"
On Thu, Oct 22, 2020 at 6:21 AM Peter Eisentraut <
peter.eisentr...@2ndquadrant.com> wrote:
> [v1]
Hi Peter,
This part created a syntax error:
--- a/src/include/catalog/unused_oids
+++ b/src/include/catalog/unused_oids
@@ -28,7 +28,7 @@ chdir $FindBin::RealBin or die "could not cd to
$FindBin::R
