Re: More test/kerberos tweaks

2021-02-26 Thread Jacob Champion
On Fri, 2021-02-05 at 21:54 +, Jacob Champion wrote: > That just leaves the first patch, then. I've moved the first patch into the commitfest entry for [1], which depends on it. --Jacob [1] https://www.postgresql.org/message-id/flat/c55788dd1773c521c862e8e0dddb367df51222be.camel%40vmware.co

Re: More test/kerberos tweaks

2021-02-05 Thread Jacob Champion
On Fri, 2021-02-05 at 15:55 -0500, Tom Lane wrote: > We have, almost invariably, regretted it when we tried to use short > timeouts in test cases. That's what I was afraid of. I can work around it easily enough on my local machine, so it's not really a blocker in any sense. That just leaves the f

Re: More test/kerberos tweaks

2021-02-05 Thread Tom Lane
Jacob Champion writes: > The second patch is more of a quality-of-life improvement for devs. On > a failed log match, the test will spin for three minutes before giving > up on the match. I think this is excessive, especially since > interrupting the test with Ctrl-C leaves behind a running KDC da

More test/kerberos tweaks

2021-02-05 Thread Jacob Champion
While working on [1] I ended up running into a couple issues with the Kerberos test suite. Attached are two patches with possible improvements: Some tests check for expected log messages. They currently search through the entire log file, from the beginning, for every match. So if two tests share