Re: Missing some ifndef FRONTEND at the top of logging.c and file_utils.c

2020-06-30 Thread Michael Paquier
On Fri, Jun 26, 2020 at 09:59:30AM +0900, Michael Paquier wrote: > Thanks. This list is provided by OBJS_FRONTEND in > src/common/Makefile, and pgcommonfrontendfiles in Mkvcbuild.pm. Let's > see if others have comments, as it just looks like something that was > forgotten in bf5bb2e and fc9a62a w

Re: Missing some ifndef FRONTEND at the top of logging.c and file_utils.c

2020-06-25 Thread Michael Paquier
On Thu, Jun 25, 2020 at 11:15:03AM +0200, Daniel Gustafsson wrote: > That makes sense, logging.c and file_utils.c are indeed only part of > libpgcommon.a and should only be compiled for frontend. Thanks. This list is provided by OBJS_FRONTEND in src/common/Makefile, and pgcommonfrontendfiles in M

Re: Missing some ifndef FRONTEND at the top of logging.c and file_utils.c

2020-06-25 Thread Daniel Gustafsson
> On 25 Jun 2020, at 10:07, Michael Paquier wrote: > So, shouldn't that stuff be added as per the attached? That makes sense, logging.c and file_utils.c are indeed only part of libpgcommon.a and should only be compiled for frontend. cheers ./daniel

Missing some ifndef FRONTEND at the top of logging.c and file_utils.c

2020-06-25 Thread Michael Paquier
Hi all, As subject tells, we have in src/common/ four files that are only compiled as part of the frontend: fe_memutils.c, file_utils.c, logging.c and restricted_token.c. Two of them are missing the following, to make sure that we never try to compile them with the backend: +#ifndef FRONTEND +#er