Re: Missing quotes when deparsing XMLTABLE() and SQL/JSON query functions

2025-01-12 Thread Dean Rasheed
On Sat, 11 Jan 2025 at 15:42, Tom Lane wrote: > > +1, but you also need to update the xml_1.out and xml_2.out files. > IIRC, xml_1.out is what comes out without --with-libxml. > I forget what's different about xml_2.out, but you can probably > just clone the diff for xml.out and be fine. > Ah yes

Re: Missing quotes when deparsing XMLTABLE() and SQL/JSON query functions

2025-01-11 Thread Tom Lane
Dean Rasheed writes: > While looking over ruleutils.c, I noticed a couple of places that fail > to properly quote certain outputs: > 1. XML namespace names in XMLTABLE(). +1, but you also need to update the xml_1.out and xml_2.out files. IIRC, xml_1.out is what comes out without --with-libxml. I

Missing quotes when deparsing XMLTABLE() and SQL/JSON query functions

2025-01-11 Thread Dean Rasheed
While looking over ruleutils.c, I noticed a couple of places that fail to properly quote certain outputs: 1. XML namespace names in XMLTABLE(). 2. variable names in the PASSING clause of the SQL/JSON query functions JSON_EXISTS(), JSON_QUERY(), and JSON_VALUE() (but not JSON_TABLE(), which has si