On 2025/06/09 13:48, Hayato Kuroda (Fujitsu) wrote:
Dear Fujii-san,
I agree with Peter. I don't think patches 0002 and 0003 are necessary.
As for 0004, it adds tests for the short options -? and -V, which
duplicate the existing tests for the long options --help and --version.
I'm not sure i
Dear Fujii-san,
> I agree with Peter. I don't think patches 0002 and 0003 are necessary.
>
> As for 0004, it adds tests for the short options -? and -V, which
> duplicate the existing tests for the long options --help and --version.
> I'm not sure it's worth adding tests just to confirm that the
On 2025/06/05 16:44, Hayato Kuroda (Fujitsu) wrote:
Dear Peter,
Thanks for the comment.
Patch 0001 looks very sensible.
I don't think we need to bother we the other ones. pg_config works
differently than the other programs anyway, because --version does not
exit the program. And pg_bsd_i
On 05.06.25 05:00, Hayato Kuroda (Fujitsu) wrote:
Dear Fujii-san,
A bit similar discussion came up before regarding pgbench and program_xxx_ok
in [1], but it seems that change was never applied.
I didn't know that, thanks for sharing. ISTM, it tried to extend function to
test the
shorter opt
Dear Peter,
Thanks for the comment.
> Patch 0001 looks very sensible.
>
> I don't think we need to bother we the other ones. pg_config works
> differently than the other programs anyway, because --version does not
> exit the program. And pg_bsd_indent is an externally maintained
> program. So
Dear Fujii-san,
> A bit similar discussion came up before regarding pgbench and program_xxx_ok
> in [1], but it seems that change was never applied.
I didn't know that, thanks for sharing. ISTM, it tried to extend function to
test the
shorter options.
While verifying the idea, I found that pg_c
On 2025/06/05 10:18, Hayato Kuroda (Fujitsu) wrote:
Dear hackers,
While reviewing another thread I found #SUBJECT.
Most of client program executes program_help_ok, program_version_ok,
program_options_handling_ok() in their test, but pgbench does not do. Instead
pgbench has own tests for --he
Dear hackers,
While reviewing another thread I found #SUBJECT.
Most of client program executes program_help_ok, program_version_ok,
program_options_handling_ok() in their test, but pgbench does not do. Instead
pgbench has own tests for --help and --version options.
One concern is that program_he
