Re: [PATCH] Missing links between system catalog documentation pages

2020-09-10 Thread Peter Eisentraut
On 2020-09-03 17:40, Dagfinn Ilmari Mannsåker wrote: I just noticed that both this and the command link patch modified the same sentence about CREATE DATABASE and pg_database, so those changes seem to have been lost in the merge. Attached is a follow-up patch that adds them both. I think in th

Re: [PATCH] Missing links between system catalog documentation pages

2020-09-03 Thread Dagfinn Ilmari Mannsåker
Hi Peter, Peter Eisentraut writes: > On 2020-06-21 19:49, Dagfinn Ilmari Mannsåker wrote: >> There were only three cases of multiple mentions of the same table in a >> single paragraph, I've removed them in the attached patch. >> >> I've also added a second patch that makes the SQL commands link

Re: [PATCH] Missing links between system catalog documentation pages

2020-09-03 Thread Peter Eisentraut
On 2020-06-21 19:49, Dagfinn Ilmari Mannsåker wrote: There were only three cases of multiple mentions of the same table in a single paragraph, I've removed them in the attached patch. I've also added a second patch that makes the SQL commands links. There were some cases of the same commands be

Re: [PATCH] Missing links between system catalog documentation pages

2020-06-21 Thread Fabien COELHO
Hello Tom, I didn't think there was much point in linkifying both in that case, and other similar situations. The point is that the user reads a sentence, attempts to jump but sometimes can't, because the is not the first occurrence. I'd go for all mentions of another relation should be li

Re: [PATCH] Missing links between system catalog documentation pages

2020-06-21 Thread Dagfinn Ilmari Mannsåker
Alvaro Herrera writes: > On 2020-Jun-21, Tom Lane wrote: > >> That has not been our practice up to now, eg in comparable cases in >> discussions of GUC variables, only the first reference is xref-ified. >> I think it could be kind of annoying to make every reference a link, >> both for regular re

Re: [PATCH] Missing links between system catalog documentation pages

2020-06-21 Thread Alvaro Herrera
On 2020-Jun-21, Tom Lane wrote: > That has not been our practice up to now, eg in comparable cases in > discussions of GUC variables, only the first reference is xref-ified. > I think it could be kind of annoying to make every reference a link, > both for regular readers (the link decoration is to

Re: [PATCH] Missing links between system catalog documentation pages

2020-06-21 Thread Tom Lane
Fabien COELHO writes: >> I didn't think there was much point in linkifying both in that case, and >> other similar situations. > The point is that the user reads a sentence, attempts to jump but > sometimes can't, because the is not the first occurrence. I'd go for all > mentions of another rel

Re: [PATCH] Missing links between system catalog documentation pages

2020-06-21 Thread Dagfinn Ilmari Mannsåker
Hi Fabien, Fabien COELHO writes: >> It's the first mention in the introductory paragraph of _each_ catalog >> table/view page, not the first mention in the entire catalogs.sgml file. >> E.g. https://www.postgresql.org/docs/current/catalog-pg-aggregate.html >> has two mentions of pg_proc one word

Re: [PATCH] Missing links between system catalog documentation pages

2020-06-21 Thread Fabien COELHO
Hello Dagfinn, The attached patch applies cleanly, doc generation is ok. I'm ok with adding such links systematically. makes the first mention of another system catalog or view (as well as pg_hba.conf in pg_hba_file_lines) a link, for easier navigation. Why only the first mention? It se

Re: [PATCH] Missing links between system catalog documentation pages

2020-06-17 Thread Dagfinn Ilmari Mannsåker
Fabien COELHO writes: > Hello Dagfinn, > >>> The attached patch makes the first mention of another system catalog or >>> view (as well as pg_hba.conf in pg_hba_file_lines) a link, for easier >>> navigation. > > Why only the first mention? It seems unlikely that I would ever read > such chapter li

Re: [PATCH] Missing links between system catalog documentation pages

2020-06-15 Thread Fabien COELHO
Hello Dagfinn, The attached patch makes the first mention of another system catalog or view (as well as pg_hba.conf in pg_hba_file_lines) a link, for easier navigation. Why only the first mention? It seems unlikely that I would ever read such chapter linearly, and even so that I would want

Re: [PATCH] Missing links between system catalog documentation pages

2020-06-15 Thread Dagfinn Ilmari Mannsåker
ilm...@ilmari.org (Dagfinn Ilmari Mannsåker) writes: > ilm...@ilmari.org (Dagfinn Ilmari Mannsåker) writes: > >> The attached patch makes the first mention of another system catalog or >> view (as well as pg_hba.conf in pg_hba_file_lines) a link, for easier >> navigation. > > bump... Added to the

[PATCH] Missing links between system catalog documentation pages

2020-06-15 Thread Dagfinn Ilmari Mannsåker
ilm...@ilmari.org (Dagfinn Ilmari Mannsåker) writes: > The attached patch makes the first mention of another system catalog or > view (as well as pg_hba.conf in pg_hba_file_lines) a link, for easier > navigation. bump... - ilmari -- "A disappointingly low fraction of the human race is, at any

Missing links between system catalog documentation pages

2020-05-24 Thread Dagfinn Ilmari Mannsåker
Hi hackers, While browsing the system catalog docs earlier I noticed that a lot of them mention other catalogs or views in the introductory paragrah without hyperlinking them. Now, most of these are linked in the "references" column in the table, but some, like pg_proc's mention of pg_aggregate h