Re: Missing comments/docs about custom scan path

2023-08-30 Thread Etsuro Fujita
Hi Richard, On Wed, Aug 30, 2023 at 11:05 AM Richard Guo wrote: > On Tue, Aug 29, 2023 at 5:08 PM Etsuro Fujita wrote: >> Another thing I would like to propose is minor adjustments to the docs >> related to parallel query: >> >> A custom scan provider will typically add paths for a base rela

Re: Missing comments/docs about custom scan path

2023-08-29 Thread Richard Guo
On Tue, Aug 29, 2023 at 5:08 PM Etsuro Fujita wrote: > Another thing I would like to propose is minor adjustments to the docs > related to parallel query: > > A custom scan provider will typically add paths for a base relation by > setting the following hook, which is called after the cor

Re: Missing comments/docs about custom scan path

2023-08-29 Thread Etsuro Fujita
On Thu, Aug 3, 2023 at 6:01 PM Etsuro Fujita wrote: > On Mon, Jul 31, 2023 at 7:05 PM Etsuro Fujita wrote: > > While working on [1], I noticed $SUBJECT: Another thing I would like to propose is minor adjustments to the docs related to parallel query: A custom scan provider will typically ad

Re: Missing comments/docs about custom scan path

2023-08-03 Thread Etsuro Fujita
On Mon, Jul 31, 2023 at 7:05 PM Etsuro Fujita wrote: > While working on [1], I noticed $SUBJECT: commit e7cb7ee14 failed to > update comments for the CustomPath struct in pathnodes.h, and commit > f49842d1e failed to update docs about custom scan path callbacks in > custom-scan.sgml, IIUC. Attach

Missing comments/docs about custom scan path

2023-07-31 Thread Etsuro Fujita
Hi, While working on [1], I noticed $SUBJECT: commit e7cb7ee14 failed to update comments for the CustomPath struct in pathnodes.h, and commit f49842d1e failed to update docs about custom scan path callbacks in custom-scan.sgml, IIUC. Attached are patches for updating these, which I created separa