Re: Missing CFI in iterate_word_similarity()

2022-09-05 Thread Daniel Gustafsson
> On 2 Sep 2022, at 15:22, Daniel Gustafsson wrote: > >> On 2 Sep 2022, at 15:16, Tom Lane wrote: > >> What's annoying me about the one-liner fix is that it makes it >> look like CFI is part of the "Get index" action. > > Thats a good point, I'll split the code up to make it clearer. Done tha

Re: Missing CFI in iterate_word_similarity()

2022-09-02 Thread Daniel Gustafsson
> On 2 Sep 2022, at 15:16, Tom Lane wrote: > What's annoying me about the one-liner fix is that it makes it > look like CFI is part of the "Get index" action. Thats a good point, I'll split the code up to make it clearer. -- Daniel Gustafsson https://vmware.com/

Re: Missing CFI in iterate_word_similarity()

2022-09-02 Thread Tom Lane
Daniel Gustafsson writes: >> On 2 Sep 2022, at 14:57, Tom Lane wrote: >> I noticed the same thing, but sticking the CFI immediately after the >> declaration didn't read well either. I was considering moving it to >> the bottom of the loop instead of that. > I was contemplating that too, but k

Re: Missing CFI in iterate_word_similarity()

2022-09-02 Thread Daniel Gustafsson
> On 2 Sep 2022, at 14:57, Tom Lane wrote: > > Daniel Gustafsson writes: >> Placing code before declarations will generate a compiler warning, so the >> check >> must go after trgindex is declared. I've fixed that in the attached to get >> the >> cfbot green. Marking this ready for committer

Re: Missing CFI in iterate_word_similarity()

2022-09-02 Thread Tom Lane
Daniel Gustafsson writes: > Placing code before declarations will generate a compiler warning, so the > check > must go after trgindex is declared. I've fixed that in the attached to get > the > cfbot green. Marking this ready for committer in the meantime. I noticed the same thing, but stick

Re: Missing CFI in iterate_word_similarity()

2022-09-02 Thread Daniel Gustafsson
> On 2 Aug 2022, at 04:41, Robins Tharakan wrote: > For long strings, iterate_word_similarity() can run into long-running > tight-loops without honouring interrupts or statement_timeouts. > Adding CHECK_FOR_INTERRUPTS() ensures that such queries respond to > statement_timeout & Ctrl-C signals. W

Missing CFI in iterate_word_similarity()

2022-08-01 Thread Robins Tharakan
Hi, For long strings, iterate_word_similarity() can run into long-running tight-loops without honouring interrupts or statement_timeouts. For example: postgres=# set statement_timeout='1s'; SET postgres=# select 1 where repeat('1.1',8) %>> 'Lorem ipsum dolor sit amet'; ?column? -- (0