On Fri, Feb 21, 2025 at 09:53:06AM -0500, Tom Lane wrote:
> If I have to actually debug or test behavior touching this, I use a
> non-reporting buildfarm instance that I have lying around, which is
> configured to run the cross-version tests and not very much else.
> I can switch that between pulli
On Fri, Feb 21, 2025 at 08:38:55PM +0900, Michael Paquier wrote:
> Thanks. I have used that after a second check. Let's see how it
> goes.
The buildfarm has turned green on v16 and v17. It is still red
because of a different issue, while mine is gone. So we should be
good.
--
Michael
signatu
Michael Paquier writes:
> On Fri, Feb 21, 2025 at 12:29:12PM +0100, Jim Jones wrote:
>> For future reference, what’s the best way to verify this myself? The
>> buildfarm was all green.
> Don't worry, we are all trapped by that at some point.
Yeah, I leave that to the buildfarm too.
If I have to
On 21.02.25 12:46, Michael Paquier wrote:
> One way would be to generate by yourself dumps from an older version
> by yourself, as documented by src/bin/pg_upgrade/TESTING, part DETAILS
> (the part about USE_MODULE_DB=1 is very important). Then you can
> reuse the SQL files by specifying an old
On Fri, Feb 21, 2025 at 12:29:12PM +0100, Jim Jones wrote:
> For future reference, what’s the best way to verify this myself? The
> buildfarm was all green.
Don't worry, we are all trapped by that at some point.
One way would be to generate by yourself dumps from an older version
by yourself, as
On Fri, Feb 21, 2025 at 05:46:52AM -0500, Andrew Dunstan wrote:
> I think so. Looks good to me
Thanks. I have used that after a second check. Let's see how it
goes.
--
Michael
signature.asc
Description: PGP signature
Hi Michael & Andrew
On 21.02.25 11:46, Andrew Dunstan wrote:
>> On Feb 21, 2025, at 4:55 AM, Michael Paquier wrote:
>>
>> On Fri, Feb 21, 2025 at 04:36:07AM -0500, Andrew Dunstan wrote:
>>> The fix has broken cross version upgrade test. Maybe we need to filter out
>>> NO INDENT in releases prior
> On Feb 21, 2025, at 4:55 AM, Michael Paquier wrote:
>
> On Fri, Feb 21, 2025 at 04:36:07AM -0500, Andrew Dunstan wrote:
>> The fix has broken cross version upgrade test. Maybe we need to filter out
>> NO INDENT in releases prior to 16 in AdjustUpgrade.pm?s
>
> Yes, I was just looking at t
On Fri, Feb 21, 2025 at 04:36:07AM -0500, Andrew Dunstan wrote:
> The fix has broken cross version upgrade test. Maybe we need to filter out
> NO INDENT in releases prior to 16 in AdjustUpgrade.pm?
Yes, I was just looking at that. The regex I am finishing with in
AdjustUpgrade.pm is something lik
On 2025-02-21 Fr 1:31 AM, Michael Paquier wrote:
On Thu, Feb 20, 2025 at 02:27:42PM +0100, Jim Jones wrote:
This patch adds the missing [NO] INDENT flag to XMLSerialize backward
parsing.
if (xexpr->op == IS_XMLSERIALIZE)
+ {
appendStringInfo(buf, " AS %s",
On Thu, Feb 20, 2025 at 02:27:42PM +0100, Jim Jones wrote:
> This patch adds the missing [NO] INDENT flag to XMLSerialize backward
> parsing.
if (xexpr->op == IS_XMLSERIALIZE)
+ {
appendStringInfo(buf, " AS %s",
format_type_with_typemod(xexpr->typ
CT XMLSERIALIZE(DOCUMENT '42'::xml AS text NO
INDENT) AS "xmlserialize"
Regression tests were updated accordingly.
Best regards, Jim
From ff1b261ef74ae381eb946ec675e0f116c728cee0 Mon Sep 17 00:00:00 2001
From: Jim Jones
Date: Thu, 20 Feb 2025 14:08:04 +0100
Subject: [PATCH v1] Fix m
12 matches
Mail list logo
