Re: Misleading comment in prologue of ReorderBufferQueueMessage

2020-12-18 Thread Amit Kapila
On Fri, Dec 18, 2020 at 3:37 PM Ashutosh Bapat wrote: > > On Wed, Dec 16, 2020 at 8:00 AM Amit Kapila wrote: >> >> How about something like below: >> A transactional message is queued to be processed upon commit and a >> non-transactional message gets processed immediately. > > > Used this one. P

Re: Misleading comment in prologue of ReorderBufferQueueMessage

2020-12-18 Thread Ashutosh Bapat
On Wed, Dec 16, 2020 at 8:00 AM Amit Kapila wrote: > On Tue, Dec 15, 2020 at 11:25 AM Ashutosh Bapat > wrote: > > > > On Mon, Dec 14, 2020 at 3:14 PM Amit Kapila > wrote: > >> > >> On Mon, Dec 14, 2020 at 2:45 PM Ashutosh Bapat > >> wrote: > >> > > >> > The name of the function suggests that t

Re: Misleading comment in prologue of ReorderBufferQueueMessage

2020-12-15 Thread Amit Kapila
On Tue, Dec 15, 2020 at 11:25 AM Ashutosh Bapat wrote: > > On Mon, Dec 14, 2020 at 3:14 PM Amit Kapila wrote: >> >> On Mon, Dec 14, 2020 at 2:45 PM Ashutosh Bapat >> wrote: >> > >> > The name of the function suggests that the given message will be queued in >> > ReorderBuffer. The prologue of t

Re: Misleading comment in prologue of ReorderBufferQueueMessage

2020-12-14 Thread Ashutosh Bapat
On Mon, Dec 14, 2020 at 3:14 PM Amit Kapila wrote: > On Mon, Dec 14, 2020 at 2:45 PM Ashutosh Bapat > wrote: > > > > The name of the function suggests that the given message will be queued > in ReorderBuffer. The prologue of the function says so too > > 776 /* > > 777 * Queue message into a t

Re: Misleading comment in prologue of ReorderBufferQueueMessage

2020-12-14 Thread Amit Kapila
On Mon, Dec 14, 2020 at 2:45 PM Ashutosh Bapat wrote: > > The name of the function suggests that the given message will be queued in > ReorderBuffer. The prologue of the function says so too > 776 /* > 777 * Queue message into a transaction so it can be processed upon commit. > 778 */ > It l

Misleading comment in prologue of ReorderBufferQueueMessage

2020-12-14 Thread Ashutosh Bapat
The name of the function suggests that the given message will be queued in ReorderBuffer. The prologue of the function says so too 776 /* 777 * Queue message into a transaction so it can be processed upon commit. 778 */ It led me to think that a non-transactional message is processed along wit