Re: Minor rework of ALTER TABLE SET RelOptions code

2025-03-18 Thread Nikolay Shaplov
В письме от пятница, 14 марта 2025 г. 11:35:15 MSK пользователь Álvaro Herrera написал: > > 1. `isnull` variable is actually needed in a very narrow scope, so > > it is better to keep it in that scope, not keeping it in mind in while > > dealing with the rest of the code. > > > > 2. Toast table

Re: Minor rework of ALTER TABLE SET RelOptions code

2025-03-14 Thread Álvaro Herrera
On 2025-Mar-07, Nikolay Shaplov wrote: > Patch description is following: > > 1. `isnull` variable is actually needed in a very narrow scope, so > > it is better to keep it in that scope, not keeping it in mind in while > > dealing with the rest of the code.

Re: Minor rework of ALTER TABLE SET RelOptions code

2025-03-13 Thread Timur Magomedov
On Fri, 2025-03-07 at 20:02 +0300, Nikolay Shaplov wrote: > While working with my New Options Engine patch > https://commitfest.postgresql.org/patch/4688/ > I found out that I can detach a small portion of it as a separate > patch. > It has own value, even if big patch is never committed, and it w

Minor rework of ALTER TABLE SET RelOptions code

2025-03-07 Thread Nikolay Shaplov
c7652afa Mon Sep 17 00:00:00 2001 From: Nikolay Shaplov Date: Fri, 7 Mar 2025 19:44:14 +0300 Subject: [PATCH v[1] 1/1] Minor rework of ALTER TABLE SET RelOptions code 1. `isnull` variable is actually needed in a very narrow scope, so it is better to keep it in that scope, not keeping it in mind