Re: Minor refactor: Use more consistent names for the labels of PG_Locale_Strategy

2024-09-01 Thread Michael Paquier
On Thu, Aug 29, 2024 at 10:06:32AM +0900, Michael Paquier wrote: > +1 for your suggestion, as you are suggesting. The original intention > when PG_Locale_Strategy got introduced was to have everything named as > PG_REGEX_LOCALE_*, but with the built-in part coming in play in this > code adding "ST

Re: Minor refactor: Use more consistent names for the labels of PG_Locale_Strategy

2024-08-28 Thread Michael Paquier
On Wed, Aug 28, 2024 at 04:58:16PM +0200, Andreas Karlsson wrote: > When working on the regex code I noticed that the labels of > PG_Locale_Strategy had become inconsistent with the addition of > PG_REGEX_BUILTIN but while at it I also noticed that PG_REGEX_LOCALE_WIDE_L > and PG_REGEX_LOCALE_1BYTE

Minor refactor: Use more consistent names for the labels of PG_Locale_Strategy

2024-08-28 Thread Andreas Karlsson
Hi, When working on the regex code I noticed that the labels of PG_Locale_Strategy had become inconsistent with the addition of PG_REGEX_BUILTIN but while at it I also noticed that PG_REGEX_LOCALE_WIDE_L and PG_REGEX_LOCALE_1BYTE_L did not make it obvious that they were libc-related so I prop