Re: Minor improvements to test log navigability

2022-05-18 Thread Peter Eisentraut
On 16.05.22 01:01, Thomas Munro wrote: 2. The TAP test logs are strangely named. Any reason not to call them 001_testname.log, instead of regress_log_001_testname, so they appear next to the corresponding 001_testname_{primary,standby,xxx}.log in directory listings (CI) and dumps (build farm, p

Re: Minor improvements to test log navigability

2022-05-16 Thread Tom Lane
Thomas Munro writes: > ... Admittedly that is nothing compared to the huge amount of extra log > spam caused by regression.diffs filling up with these: Yeah, that's really the main problem. > I wonder if there would be a good way to filter those "never managed > to connect" cases out... Exit co

Re: Minor improvements to test log navigability

2022-05-16 Thread Thomas Munro
On Tue, May 17, 2022 at 4:18 AM Tom Lane wrote: > Alvaro Herrera writes: > > On 2022-May-16, Thomas Munro wrote: > >> 1. It seems a bit useless to have a load of "FATAL: the database > >> system is in recovery mode" spam whenever the server crashes under > >> src/test/regress. Any reason not t

Re: Minor improvements to test log navigability

2022-05-16 Thread Michael Paquier
On Mon, May 16, 2022 at 12:18:24PM -0400, Tom Lane wrote: > Andrew would have to weigh in on whether this'd break the buildfarm, > but if it doesn't, +1. FWIW, the buildfarm client feeds from the contents of the directory tmp_check/log/, so a simple renaming of the main log file would have no impa

Re: Minor improvements to test log navigability

2022-05-16 Thread Tom Lane
Alvaro Herrera writes: > On 2022-May-16, Thomas Munro wrote: >> 1. It seems a bit useless to have a load of "FATAL: the database >> system is in recovery mode" spam whenever the server crashes under >> src/test/regress. Any reason not to just turn that off, as we do for >> the TAP tests? > I d

Re: Minor improvements to test log navigability

2022-05-16 Thread Alvaro Herrera
On 2022-May-16, Thomas Munro wrote: > 1. It seems a bit useless to have a load of "FATAL: the database > system is in recovery mode" spam whenever the server crashes under > src/test/regress. Any reason not to just turn that off, as we do for > the TAP tests? I don't know of any. Let's. > 2.

Minor improvements to test log navigability

2022-05-15 Thread Thomas Munro
Hi, Speaking as someone who regularly trawls through megabytes of build farm output: 1. It seems a bit useless to have a load of "FATAL: the database system is in recovery mode" spam whenever the server crashes under src/test/regress. Any reason not to just turn that off, as we do for the TAP