On 17/05/18 00:56, Alexander Korotkov wrote:
On Wed, May 16, 2018 at 10:41 PM, Andres Freund wrote:
Generally ok, two minor points:
diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c
index 7cd2d2d80e..93402030f7 100644
{"TB", GUC_UNIT_BLOCKS, (1024 * 1024 * 1024)
On Wed, May 16, 2018 at 10:41 PM, Andres Freund wrote:
> On 2018-05-16 15:49:29 +0300, Heikki Linnakangas wrote:
> > Here's a pretty straightforward fix for these two issues. Any objections
> or
> > better ideas?
>
> Generally ok, two minor points:
>
> > diff --git a/src/backend/utils/misc/guc.c
Hi,
On 2018-05-16 15:49:29 +0300, Heikki Linnakangas wrote:
> Here's a pretty straightforward fix for these two issues. Any objections or
> better ideas?
Generally ok, two minor points:
> diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c
> index 7cd2d2d80e..93402030f7 1006
On 16/05/18 16:35, Alexander Korotkov wrote:
I also think it would be nice to show units in the valid range. I image
that if I would see such message at the first time, then I would try to
reverse-engineer units from input value representation in the error
message. Displaying units in the valid
On Wed, May 16, 2018 at 3:49 PM, Heikki Linnakangas wrote:
> On 16/05/18 15:19, Heikki Linnakangas wrote:
>
>> $ postmaster -c track_activity_query_size=1024TB
>> FATAL: invalid value for parameter "track_activity_query_size": "1024TB"
>> HINT: Valid units for this parameter are "kB", "MB", "GB
Hi!
On Wed, May 16, 2018 at 3:19 PM, Heikki Linnakangas wrote:
> I played around with the GUC memory units, specifically to test the new
> GUC_UNIT_BYTES flag (commit 6e7baa32):
>
> $ postmaster -c track_activity_query_size=1024kB
> FATAL: 1048576 is outside the valid range for parameter
> "tra
On 16/05/18 15:19, Heikki Linnakangas wrote:
$ postmaster -c track_activity_query_size=1024TB
FATAL: invalid value for parameter "track_activity_query_size": "1024TB"
HINT: Valid units for this parameter are "kB", "MB", "GB", and "TB".
...
The HINT in the last message seems wrong: the hint cl
Hi,
I played around with the GUC memory units, specifically to test the new
GUC_UNIT_BYTES flag (commit 6e7baa32):
$ postmaster -c track_activity_query_size=1024kB
FATAL: 1048576 is outside the valid range for parameter
"track_activity_query_size" (100 .. 102400)
$ postmaster -c track_acti
