Re: Memory leak fix in rmtree.c

2024-02-06 Thread Daniel Gustafsson
> On 6 Feb 2024, at 12:45, Ильясов Ян wrote: > > I agree with your argument. > Thank you for your time. Thank you for your report! -- Daniel Gustafsson

RE: Memory leak fix in rmtree.c

2024-02-06 Thread Ильясов Ян
I agree with your argument. Thank you for your time. Kind regards, Ian Ilyasov Juniour Software Developer at Postgres Professional

Re: Memory leak fix in rmtree.c

2024-02-06 Thread Daniel Gustafsson
> On 6 Feb 2024, at 11:21, Ильясов Ян wrote: > > > dirnames isn't allocated at this point, it's palloc'd after this return > > statement on line 67. > > I am sorry, I pointed on the wrong branch. I see that in master > it is really in line 67th , and the allocation goes well. But in > REL_16_STA

RE: Memory leak fix in rmtree.c

2024-02-06 Thread Ильясов Ян
> dirnames isn't allocated at this point, it's palloc'd after this return > statement on line 67. > > -- > Daniel Gustafsson I am sorry, I pointed on the wrong branch. I see that in master it is really in line 67th , and the allocation goes well. But in REL_16_STABLE the allocation is in line 58th

Re: Memory leak fix in rmtree.c

2024-02-06 Thread Daniel Gustafsson
> On 6 Feb 2024, at 10:34, Ильясов Ян wrote: > Just like some of my colleagues I've been using Svace* > and I think I've found a bug in src/common/rmtree.c . > > In 64th line function returns false in case it couldn't open a directory, > but the memory, that have been allocated for char** dirnam

Memory leak fix in rmtree.c

2024-02-06 Thread Ильясов Ян
Hello hackers, Just like some of my colleagues I've been using Svace* and I think I've found a bug in src/common/rmtree.c . In 64th line function returns false in case it couldn't open a directory, but the memory, that have been allocated for char** dirnames is not freed. The patch that has a fi