Re: Memory error in src/backend/replication/logical/origin.c

2017-11-26 Thread Mark Dilger
> On Nov 26, 2017, at 10:28 AM, Tom Lane wrote: > > Mark Dilger writes: >>boolnulls[Natts_pg_replication_origin]; >>memset(&nulls, 0, sizeof(nulls)); > >> around lines 277 through 303. Patch below. > > AFAIK this is not a bug, though I agree that dropping the "&"

Re: Memory error in src/backend/replication/logical/origin.c

2017-11-26 Thread Tom Lane
Mark Dilger writes: > boolnulls[Natts_pg_replication_origin]; > memset(&nulls, 0, sizeof(nulls)); > around lines 277 through 303. Patch below. AFAIK this is not a bug, though I agree that dropping the "&" is probably better style. The reason is that applying "&" to

Memory error in src/backend/replication/logical/origin.c

2017-11-26 Thread Mark Dilger
Hackers, boolnulls[Natts_pg_replication_origin]; ... memset(&nulls, 0, sizeof(nulls)); around lines 277 through 303. Patch below. mark diff --git a/src/backend/replication/logical/origin.c b/src/backend/replication/logical/origin.c index 55382b4b24..88188bd190 10