> On Nov 26, 2017, at 10:28 AM, Tom Lane wrote:
>
> Mark Dilger writes:
>>boolnulls[Natts_pg_replication_origin];
>>memset(&nulls, 0, sizeof(nulls));
>
>> around lines 277 through 303. Patch below.
>
> AFAIK this is not a bug, though I agree that dropping the "&"
Mark Dilger writes:
> boolnulls[Natts_pg_replication_origin];
> memset(&nulls, 0, sizeof(nulls));
> around lines 277 through 303. Patch below.
AFAIK this is not a bug, though I agree that dropping the "&" is probably
better style. The reason is that applying "&" to
Hackers,
boolnulls[Natts_pg_replication_origin];
...
memset(&nulls, 0, sizeof(nulls));
around lines 277 through 303. Patch below.
mark
diff --git a/src/backend/replication/logical/origin.c
b/src/backend/replication/logical/origin.c
index 55382b4b24..88188bd190 10