Re: Making pg_rewind faster

2022-11-29 Thread Michael Paquier
On Thu, Oct 06, 2022 at 04:08:45PM +0900, Michael Paquier wrote: > file_entry_t has an entry to track if a file is a relation file. I > think that it would be much cleaner to track if we are handling a WAL > segment when inserting an entry in insert_filehash_entry(), so > isrelfile could be replac

Re: Making pg_rewind faster

2022-10-06 Thread Michael Paquier
On Sun, Oct 02, 2022 at 10:44:25AM -0700, Andres Freund wrote: > It doesn't seem quite right to read pg_rewind's logs by reading > regress_log_001_basic. Too easy to confuse different runs of pg_rewind > etc. I'd suggest trying to redirect the log to a different file. Hardcoding log file names in

Re: Making pg_rewind faster

2022-10-02 Thread Andres Freund
Hi, On 2022-09-13 20:50:20 +0300, Alexander Korotkov wrote: > On Fri, Jul 29, 2022 at 1:05 PM Justin Kwan wrote: > > Not sure if this email went through previously but thank you for your > > feedback, I've incorporated your suggestions by scanning the logs produced > > from pg_rewind when asser

Re: Making pg_rewind faster

2022-09-13 Thread Alexander Korotkov
Hi, Justin! On Fri, Jul 29, 2022 at 1:05 PM Justin Kwan wrote: > Not sure if this email went through previously but thank you for your > feedback, I've incorporated your suggestions by scanning the logs produced > from pg_rewind when asserting that certain WAL segment files were skipped > from

Re: Making pg_rewind faster

2022-07-29 Thread Justin Kwan
an ; hlinn...@iki.fi Subject: Re: Making pg_rewind faster Hi Tom, Thank you for taking a look at this and that sounds good. I will send over a patch compatible with Postgres v16. Justin From: Tom Lane Sent: July 17, 2022 2:40 PM To: Justin Kwan Cc: pgs

Re: Making pg_rewind faster

2022-07-20 Thread Justin Kwan
Re: Making pg_rewind faster On Mon, Jul 18, 2022 at 05:14:00PM +, Justin Kwan wrote: > Thank you for taking a look at this and that sounds good. I will > send over a patch compatible with Postgres v16. +$node_2->psql( + 'postgres', + "SELECT extract(epoch fro

Re: Making pg_rewind faster

2022-07-18 Thread Michael Paquier
On Mon, Jul 18, 2022 at 05:14:00PM +, Justin Kwan wrote: > Thank you for taking a look at this and that sounds good. I will > send over a patch compatible with Postgres v16. +$node_2->psql( + 'postgres', + "SELECT extract(epoch from modification) FROM pg_stat_file('pg_wal/0001

Re: Making pg_rewind faster

2022-07-18 Thread Justin Kwan
ravichandran ; hlinn...@iki.fi Subject: Re: Making pg_rewind faster Justin Kwan writes: > I've also attached the pg_rewind optimization patch file for Postgres version > 14.4. The previous patch file targets version Postgres version 15 Beta 1/2. It's very unlikely that we would consider

Re: Making pg_rewind faster

2022-07-17 Thread Tom Lane
Justin Kwan writes: > I've also attached the pg_rewind optimization patch file for Postgres version > 14.4. The previous patch file targets version Postgres version 15 Beta 1/2. It's very unlikely that we would consider committing such changes into released branches. In fact, it's too late even

Re: Making pg_rewind faster

2022-07-17 Thread Justin Kwan
ustin From: Justin Kwan Sent: July 15, 2022 6:13 PM To: vignesh ravichandran Cc: pgsql-hackers ; vignesh ; justinpk...@outlook.com Subject: Re: Making pg_rewind faster Looping in my other email. On Thu, Jun 30, 2022 at 6:22 AM vignesh ravichandran mailto:ad...@vi

Re: Making pg_rewind faster

2022-07-17 Thread Justin Kwan
n Cc: pgsql-hackers ; vignesh ; justinpk...@outlook.com Subject: Re: Making pg_rewind faster Looping in my other email. On Thu, Jun 30, 2022 at 6:22 AM vignesh ravichandran mailto:ad...@viggy28.dev>> wrote: Hi Hackers, I have been using pg_rewind in production for 2 years. One of the th

Making pg_rewind faster

2022-06-30 Thread vignesh ravichandran
Hi Hackers, I have been using pg_rewind in production for 2 years. One of the things that I noticed in pg_rewind is if it doesn't know what to do with a file "it copies". I understand it's the more safer option. After all, the alternative, pg_basebackup copies all the files from source to tar