Re: Make pgbench exit on SIGINT more reliably

2023-07-11 Thread Tristan Partin
On Mon Jul 10, 2023 at 10:29 PM CDT, Michael Paquier wrote: > On Tue, Jun 27, 2023 at 09:42:05AM -0500, Tristan Partin wrote: > > I would say there probably isn't much benefit if you think the polling > > for CancelRequested is fine. Looking at the other patch, I think it > > might be simple to add

Re: Make pgbench exit on SIGINT more reliably

2023-07-10 Thread Michael Paquier
On Tue, Jun 27, 2023 at 09:42:05AM -0500, Tristan Partin wrote: > I would say there probably isn't much benefit if you think the polling > for CancelRequested is fine. Looking at the other patch, I think it > might be simple to add an exit code for SIGINT. But I think it might be > best to do it af

Re: Make pgbench exit on SIGINT more reliably

2023-06-27 Thread Tristan Partin
On Thu Jun 22, 2023 at 6:19 PM CDT, Michael Paquier wrote: > On Thu, Jun 22, 2023 at 02:58:14PM +0900, Yugo NAGATA wrote: > > On Mon, 19 Jun 2023 16:49:05 -0700 > > "Tristan Partin" wrote: > >> On Mon Jun 19, 2023 at 6:39 AM PDT, Yugo NAGATA wrote: > >>> [1] > >>> https://www.postgresql.org/messa

Re: Make pgbench exit on SIGINT more reliably

2023-06-22 Thread Michael Paquier
On Thu, Jun 22, 2023 at 02:58:14PM +0900, Yugo NAGATA wrote: > On Mon, 19 Jun 2023 16:49:05 -0700 > "Tristan Partin" wrote: >> On Mon Jun 19, 2023 at 6:39 AM PDT, Yugo NAGATA wrote: >>> [1] >>> https://www.postgresql.org/message-id/flat/CSTU5P82ONZ1.19XFUGHMXHBRY%40c3po >> >> The other patch doe

Re: Make pgbench exit on SIGINT more reliably

2023-06-21 Thread Yugo NAGATA
On Mon, 19 Jun 2023 16:49:05 -0700 "Tristan Partin" wrote: > On Mon Jun 19, 2023 at 6:39 AM PDT, Yugo NAGATA wrote: > > On Wed, 24 May 2023 08:58:46 -0500 > > "Tristan Partin" wrote: > > > > > On Tue May 23, 2023 at 7:31 PM CDT, Michael Paquier wrote: > > > > On Mon, May 22, 2023 at 10:02:02AM -

Re: Make pgbench exit on SIGINT more reliably

2023-06-19 Thread Tristan Partin
On Mon Jun 19, 2023 at 6:39 AM PDT, Yugo NAGATA wrote: > On Wed, 24 May 2023 08:58:46 -0500 > "Tristan Partin" wrote: > > > On Tue May 23, 2023 at 7:31 PM CDT, Michael Paquier wrote: > > > On Mon, May 22, 2023 at 10:02:02AM -0500, Tristan Partin wrote: > > > > The way that pgbench handled SIGINT c

Re: Make pgbench exit on SIGINT more reliably

2023-06-19 Thread Yugo NAGATA
On Wed, 24 May 2023 08:58:46 -0500 "Tristan Partin" wrote: > On Tue May 23, 2023 at 7:31 PM CDT, Michael Paquier wrote: > > On Mon, May 22, 2023 at 10:02:02AM -0500, Tristan Partin wrote: > > > The way that pgbench handled SIGINT changed in > > > 1d468b9ad81b9139b4a0b16b416c3597925af4b0. Unfortun

Re: Make pgbench exit on SIGINT more reliably

2023-05-30 Thread Tristan Partin
Did not even remember sending an original reply. Disregard. -- Tristan Partin Neon (https://neon.tech)

Re: Make pgbench exit on SIGINT more reliably

2023-05-30 Thread Tristan Partin
On Tue May 23, 2023 at 7:31 PM CDT, Michael Paquier wrote: > On Mon, May 22, 2023 at 10:02:02AM -0500, Tristan Partin wrote: > > The way that pgbench handled SIGINT changed in > > 1d468b9ad81b9139b4a0b16b416c3597925af4b0. Unfortunately this had a > > couple of unintended consequences, at least from

Re: Make pgbench exit on SIGINT more reliably

2023-05-24 Thread Tristan Partin
On Tue May 23, 2023 at 7:31 PM CDT, Michael Paquier wrote: > On Mon, May 22, 2023 at 10:02:02AM -0500, Tristan Partin wrote: > > The way that pgbench handled SIGINT changed in > > 1d468b9ad81b9139b4a0b16b416c3597925af4b0. Unfortunately this had a > > couple of unintended consequences, at least from

Re: Make pgbench exit on SIGINT more reliably

2023-05-23 Thread Michael Paquier
On Mon, May 22, 2023 at 10:02:02AM -0500, Tristan Partin wrote: > The way that pgbench handled SIGINT changed in > 1d468b9ad81b9139b4a0b16b416c3597925af4b0. Unfortunately this had a > couple of unintended consequences, at least from what I can tell[1]. > > - CTRL-C no longer stops the program unle

Re: Make pgbench exit on SIGINT more reliably

2023-05-22 Thread Tristan Partin
Here is a v2 that handles the Windows case that I seemingly missed in my first readthrough of this code. -- Tristan Partin Neon (https://neon.tech) From 3cff6aec8f154eb8a47524efc15f16a6b7e95f37 Mon Sep 17 00:00:00 2001 From: Tristan Partin Date: Mon, 22 May 2023 08:07:37 -0500 Subject: [PATCH po

Make pgbench exit on SIGINT more reliably

2023-05-22 Thread Tristan Partin
Hello, The way that pgbench handled SIGINT changed in 1d468b9ad81b9139b4a0b16b416c3597925af4b0. Unfortunately this had a couple of unintended consequences, at least from what I can tell[1]. - CTRL-C no longer stops the program unless the right point in pgbench execution is hit - pgbench no long