On Tue, Nov 13, 2018 at 04:04:29PM +, Bossart, Nathan wrote:
> Thanks for the updated patch. It looks good to me.
Thanks for double-checking. Committed.
--
Michael
signature.asc
Description: PGP signature
On 11/9/18, 6:11 PM, "Michael Paquier" wrote:
> This thread needed a new patch to answer to the previous comment from
> Nathan, and it was not marked as waiting on author. Sorry I got
> confused with the CF status and I have missed Nathan's update, which
> mentions a good idea. So attached is an
On Fri, Nov 09, 2018 at 04:23:57PM +0100, Dmitry Dolgov wrote:
> This thread is being inactive for quite some time. As far as I understand, the
> agreement was to add it in the PG12 commit cycle, so probably it's a good time
> to do so. Any plans about that?
This thread needed a new patch to answe
> On Fri, 15 Jun 2018 at 17:09, Nathan Bossart wrote:
>
> The following review has been posted through the commitfest application:
> make installcheck-world: not tested
> Implements feature: not tested
> Spec compliant: not tested
> Documentation:not tested
>
> -
The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: not tested
Spec compliant: not tested
Documentation:not tested
- appendStringInfo(buf, "off %u", xlrec->offnum);
+
On Tue, May 15, 2018 at 02:32:55PM -0700, Andres Freund wrote:
> I have an *extremely* hard time that'd ever be the case. And it'd not
> really change much, given several years of back branch releases.
> Anyway, I'm only -0.1 here.
I personally don't care much if this gets in v11 or later in v12 a
On 2018-05-15 16:28:23 -0500, Jonathan S. Katz wrote:
>
> > On May 15, 2018, at 12:50 PM, Andres Freund wrote:
> >
> > On 2018-05-15 13:44:58 -0400, Alvaro Herrera wrote:
> >> On 2018-Apr-23, Alvaro Herrera wrote:
> >>
> >>> Now, frankly, this being mostly a debugging tool, I think it would be
> On May 15, 2018, at 12:50 PM, Andres Freund wrote:
>
> On 2018-05-15 13:44:58 -0400, Alvaro Herrera wrote:
>> On 2018-Apr-23, Alvaro Herrera wrote:
>>
>>> Now, frankly, this being mostly a debugging tool, I think it would be
>>> better to have the output as complete as we can. Otherwise, whe
On 2018-05-15 13:44:58 -0400, Alvaro Herrera wrote:
> On 2018-Apr-23, Alvaro Herrera wrote:
>
> > Now, frankly, this being mostly a debugging tool, I think it would be
> > better to have the output as complete as we can. Otherwise, when
> > debugging some hideous problem we find ourselves patchin
On 2018-Apr-23, Alvaro Herrera wrote:
> Now, frankly, this being mostly a debugging tool, I think it would be
> better to have the output as complete as we can. Otherwise, when
> debugging some hideous problem we find ourselves patching the tool
> during an emergency in order to figure out what i
Hi all,
Bellow a 1ยข on feedback from a side project about this.
On Mon, 23 Apr 2018 12:37:20 -0300
Alvaro Herrera wrote:
> Michael Paquier wrote:
> > On Thu, Apr 12, 2018 at 08:49:03PM -0700, Andres Freund wrote:
> > > OTOH, that also kinda bloats the output noticeably... I'm somewhat
> > > i
On Mon, Apr 23, 2018 at 01:02:16PM -0300, Alvaro Herrera wrote:
> Andres Freund wrote:
> > On 2018-04-23 12:37:20 -0300, Alvaro Herrera wrote:
> > > Me too. Should we consider this for pg11? My vote is yes, with no
> > > backpatch (might break scripts reading pg_{wal,xlog}dump output.
> > > Thoug
Hello
Andres Freund wrote:
> On 2018-04-23 12:37:20 -0300, Alvaro Herrera wrote:
> > Michael Paquier wrote:
> > > On Thu, Apr 12, 2018 at 08:49:03PM -0700, Andres Freund wrote:
> > > > OTOH, that also kinda bloats the output noticeably... I'm
> > > > somewhat inclined to just put the hex value or
Hi,
On 2018-04-23 12:37:20 -0300, Alvaro Herrera wrote:
> Michael Paquier wrote:
> > On Thu, Apr 12, 2018 at 08:49:03PM -0700, Andres Freund wrote:
> > > OTOH, that also kinda bloats the output noticeably... I'm somewhat
> > > inclined to just put the hex value or such there?
> >
> > That would d
Michael Paquier wrote:
> On Thu, Apr 12, 2018 at 08:49:03PM -0700, Andres Freund wrote:
> > OTOH, that also kinda bloats the output noticeably... I'm somewhat
> > inclined to just put the hex value or such there?
>
> That would do as well for me.
Me too. Should we consider this for pg11? My vot
On Thu, Apr 12, 2018 at 08:49:03PM -0700, Andres Freund wrote:
> OTOH, that also kinda bloats the output noticeably... I'm somewhat
> inclined to just put the hex value or such there?
That would do as well for me.
--
Michael
signature.asc
Description: PGP signature
On 2018-04-13 12:47:34 +0900, Michael Paquier wrote:
> Hi all,
>
> I was just playing with the WAL consistency issue with rows moved across
> partitions when I noticed that heapdesc.c is not really talkative about
> the different flag records set.
>
> What about something like the patch attached?
Hi all,
I was just playing with the WAL consistency issue with rows moved across
partitions when I noticed that heapdesc.c is not really talkative about
the different flag records set.
What about something like the patch attached? I found that useful for
debugging.
(One comment of heapam_xlog.h
18 matches
Mail list logo