Re: Make contrib modules' installation scripts more secure.

2020-08-12 Thread Christoph Berg
Re: Tom Lane > > (The Debian regression tests remove plpgsql before testing all > > extensions in turn.) > > Meh. I think that's testing a case that we don't guarantee to work. > There was already a plpgsql dependency in hstore--1.1--1.2.sql, > which I just cribbed from to make these fixes. The

Re: Make contrib modules' installation scripts more secure.

2020-08-11 Thread Tom Lane
Christoph Berg writes: > I think this change neglected to add plpgsql to the extension > dependencies in the .control file: Adding plpgsql to the extension's dependencies would be a cure worse than the disease: it'd mean that you could not remove plpgsql from the system after installing cube, eit

Re: Make contrib modules' installation scripts more secure.

2020-08-11 Thread Christoph Berg
Re: To PostgreSQL Hackers > I think this change neglected to add plpgsql to the extension > dependencies in the .control file: > > 12:53:51 # Failed test 'psql -qc 'CREATE EXTENSION "cube"'' > 12:53:51 # at t/TestLib.pm line 213. > 12:53:51 not ok 68 - psql -qc 'CREATE EXTENSION "cube"' > 12:5

Re: Make contrib modules' installation scripts more secure.

2020-08-11 Thread Christoph Berg
I think this change neglected to add plpgsql to the extension dependencies in the .control file: 12:53:51 # Failed test 'psql -qc 'CREATE EXTENSION "cube"'' 12:53:51 # at t/TestLib.pm line 213. 12:53:51 not ok 68 - psql -qc 'CREATE EXTENSION "cube"' 12:53:51 # got: '1' 12:53:51 #