Re: Logical walsenders don't process XLOG_CHECKPOINT_SHUTDOWN

2023-07-25 Thread Amit Kapila
On Tue, Jul 25, 2023 at 10:33 PM Andres Freund wrote: > > On 2023-07-25 14:31:00 +0530, Amit Kapila wrote: > > To ensure that all the data has been sent during the upgrade, we can > > ensure that each logical slot's confirmed_flush_lsn (position in the > > WAL till which subscriber has confirmed t

Re: Logical walsenders don't process XLOG_CHECKPOINT_SHUTDOWN

2023-07-25 Thread Andres Freund
Hi, On 2023-07-25 14:31:00 +0530, Amit Kapila wrote: > To ensure that all the data has been sent during the upgrade, we can > ensure that each logical slot's confirmed_flush_lsn (position in the > WAL till which subscriber has confirmed that it has applied the WAL) > is the same as current_wal_ins

Logical walsenders don't process XLOG_CHECKPOINT_SHUTDOWN

2023-07-25 Thread Amit Kapila
Currently, we don't perform $SUBJECT at the time of shutdown of the server. I think currently it will only have a minor impact that after restart subscribers will ask to start processing before the XLOG_CHECKPOINT_SHUTDOWN or maybe after the switchover the old publisher will have an extra WAL recor