Re: Logical WAL sender unresponsive during decoding commit

2022-10-22 Thread Amit Kapila
On Thu, Oct 20, 2022 at 7:17 PM Robert Haas wrote: > > On Thu, Oct 20, 2022 at 1:37 AM Amit Kapila wrote: > > On Thu, Oct 20, 2022 at 5:17 AM Robert Haas wrote: > > > > Pushed. > > > > > > I think this was a good change, but there's at least one other problem > > > here: within ReorderBufferRest

Re: Logical WAL sender unresponsive during decoding commit

2022-10-20 Thread Robert Haas
On Thu, Oct 20, 2022 at 1:37 AM Amit Kapila wrote: > On Thu, Oct 20, 2022 at 5:17 AM Robert Haas wrote: > > > Pushed. > > > > I think this was a good change, but there's at least one other problem > > here: within ReorderBufferRestoreChanges, the while (restored < > > max_changes_in_memory && *se

Re: Logical WAL sender unresponsive during decoding commit

2022-10-19 Thread Amit Kapila
On Thu, Oct 20, 2022 at 5:17 AM Robert Haas wrote: > > > > Pushed. > > I think this was a good change, but there's at least one other problem > here: within ReorderBufferRestoreChanges, the while (restored < > max_changes_in_memory && *segno <= last_segno) doesn't seem to contain > a CFI. Note tha

Re: Logical WAL sender unresponsive during decoding commit

2022-10-19 Thread Robert Haas
On Tue, Aug 23, 2022 at 4:40 AM Amit Kapila wrote: > On Mon, Aug 22, 2022 at 4:48 PM Amit Kapila wrote: > > On Tue, Aug 16, 2022 at 2:37 PM Masahiko Sawada > > wrote: > > > I've attached patches for all supported branches. > > > > LGTM. I'll push this tomorrow unless there are comments/suggesti

Re: Logical WAL sender unresponsive during decoding commit

2022-08-23 Thread Amit Kapila
On Mon, Aug 22, 2022 at 4:48 PM Amit Kapila wrote: > > On Tue, Aug 16, 2022 at 2:37 PM Masahiko Sawada wrote: > > > > I've attached patches for all supported branches. > > > > LGTM. I'll push this tomorrow unless there are comments/suggestions. > Pushed. -- With Regards, Amit Kapila.

Re: Logical WAL sender unresponsive during decoding commit

2022-08-22 Thread Amit Kapila
On Tue, Aug 16, 2022 at 2:37 PM Masahiko Sawada wrote: > > I've attached patches for all supported branches. > LGTM. I'll push this tomorrow unless there are comments/suggestions. -- With Regards, Amit Kapila.

Re: Logical WAL sender unresponsive during decoding commit

2022-08-16 Thread Masahiko Sawada
On Tue, Aug 16, 2022 at 2:32 PM Masahiko Sawada wrote: > > On Tue, Aug 16, 2022 at 2:31 PM Amit Kapila wrote: > > > > On Tue, Aug 16, 2022 at 10:56 AM Masahiko Sawada > > wrote: > > > > > > On Tue, Aug 16, 2022 at 2:08 PM Amit Kapila > > > wrote: > > > > > > > > On Tue, Aug 16, 2022 at 9:28 A

Re: Logical WAL sender unresponsive during decoding commit

2022-08-16 Thread Andrey Borodin
> On 16 Aug 2022, at 10:25, Masahiko Sawada wrote: > > The same issue is recently reported[1] on -bugs Oh, I missed that thread. > and I proposed the > patch that adds CHECK_FOR_INTERRUPTS() to the loop in > ReorderBufferProcessTXN(). I agree that it's a good place for check. > I think it sh

Re: Logical WAL sender unresponsive during decoding commit

2022-08-15 Thread Masahiko Sawada
On Tue, Aug 16, 2022 at 2:31 PM Amit Kapila wrote: > > On Tue, Aug 16, 2022 at 10:56 AM Masahiko Sawada > wrote: > > > > On Tue, Aug 16, 2022 at 2:08 PM Amit Kapila wrote: > > > > > > On Tue, Aug 16, 2022 at 9:28 AM Andrey Borodin > > > wrote: > > > > > > > > Hi hackers! > > > > > > > > Some

Re: Logical WAL sender unresponsive during decoding commit

2022-08-15 Thread Amit Kapila
On Tue, Aug 16, 2022 at 10:56 AM Masahiko Sawada wrote: > > On Tue, Aug 16, 2022 at 2:08 PM Amit Kapila wrote: > > > > On Tue, Aug 16, 2022 at 9:28 AM Andrey Borodin wrote: > > > > > > Hi hackers! > > > > > > Some time ago I've seen a hanging logical replication that was trying to > > > send tr

Re: Logical WAL sender unresponsive during decoding commit

2022-08-15 Thread Masahiko Sawada
On Tue, Aug 16, 2022 at 2:08 PM Amit Kapila wrote: > > On Tue, Aug 16, 2022 at 9:28 AM Andrey Borodin wrote: > > > > Hi hackers! > > > > Some time ago I've seen a hanging logical replication that was trying to > > send transaction commit after doing table pg_repack. > > I understand that those t

Re: Logical WAL sender unresponsive during decoding commit

2022-08-15 Thread Amit Kapila
On Tue, Aug 16, 2022 at 9:28 AM Andrey Borodin wrote: > > Hi hackers! > > Some time ago I've seen a hanging logical replication that was trying to send > transaction commit after doing table pg_repack. > I understand that those things do not mix well. Yet walsender was ignoring > pg_terminate_ba

Logical WAL sender unresponsive during decoding commit

2022-08-15 Thread Andrey Borodin
Hi hackers! Some time ago I've seen a hanging logical replication that was trying to send transaction commit after doing table pg_repack. I understand that those things do not mix well. Yet walsender was ignoring pg_terminate_backend() and I think this worth fixing. Can we add CHECK_FOR_INTERRUP